Woocommerce responsive images

  • Resolved cpucpu

    (@cpucpu)


    8 years, 10 months ago

    Works ok for the most part, but it is not creating relative urls for woocommerce responsive images, the srcset attribute.

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author Sami Ahmed Siddiqui

    (@sasiddiqui)

    8 years, 10 months ago

    Hi @cpucpu

    Thanks for providing the feedback. We will check the issue and get back to you.

    Regards,
    Sami

    Plugin Author Sami Ahmed Siddiqui

    (@sasiddiqui)

    8 years, 10 months ago

    Hi @cpucpu

    srcset attribute has been fixed. Please try the latest version of the plugin and provide your valueable feedback.

    Thanks,
    Sami

    Thread Starter cpucpu

    (@cpucpu)

    8 years, 10 months ago

    Src attributes seem fixed. Noticed 2 more bugs though.

    1)href attributes with a trailing slash are not converted to relative path

    e.g.
    <a href="http://localhost/"> won’t
    <a href="http://localhost"> will

    2)Protocol-relative urls like in some javascript files are not converted to relative path

    e.g.
    <script src="//localhost/file.js"></script> won’t
    <script src="localhost/file.js"></script> will

    • This reply was modified 8 years, 10 months ago by cpucpu.
    Plugin Author Aliya Yasir

    (@aliya-yasir)

    8 years, 10 months ago

    @cpucpu Thanks for the reporting protocol issue. This issue has been fixed in version 0.4.

    Thanks,
    Aliya

    Thread Starter cpucpu

    (@cpucpu)

    8 years, 10 months ago

    Responsive images are not loading now, Src URLs are being generated with 3 slashes
    srcset="///wp-content/uploads/2017/03/iphone-5s-negro-300x300.jpg 300w, ///wp-content/uploads/2017/03/iphone-5s-negro-150x150.jpg 150w, ///wp-content/uploads/2017/03/iphone-5s-negro-180x180.jpg 180w"

    Plugin Author Aliya Yasir

    (@aliya-yasir)

    8 years, 10 months ago

    @cpucpu Responsive images Issue has been fixed.

    Thread Starter cpucpu

    (@cpucpu)

    8 years, 10 months ago

    I just checked the update, seems good now. Great work, I tried other plugins and this is the one that works fine with newer versions of WP.

    • This reply was modified 8 years, 10 months ago by cpucpu.
    Plugin Author Aliya Yasir

    (@aliya-yasir)

    8 years, 10 months ago

    @cpucpu I doesn’t get you. What’s the bug you are facing now. It’s working fine for me.

    Please share issue so, we can help you out.

    Thread Starter cpucpu

    (@cpucpu)

    8 years, 10 months ago

    I had already upated my answer after further testing, have a nice day.

    Plugin Author Sami Ahmed Siddiqui

    (@sasiddiqui)

    8 years, 10 months ago

    @cpucpu Thanks for providing your feedback. Have a good day 🙂

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘Woocommerce responsive images’ is closed to new replies.