WooCommerce Subscriptions – Change payment method bug

Hi,

I’d like to report a bug that I’ve discovered when combining your plugin with WooCommerce subscriptions. The scenario is the following:

• A customer has an ongoing subscription on a site using WooCommerce subscriptions.
• They’ve used payment method X for this (it doesn’t matter which payment method it is)
• Now they have a pending or failed renewal order on their account that they would like to make a payment on.
• When paying for this order they’re using any payment method that is supplied through Payment plugins for Stripe – lets for now say that you use the credit card option
• The payment is successful and the subscription is now active
• However – the payment method registered on the subscription remains as X – not Credit card as we just used.
• The latest renewal order has the correct payment method though. So we’ve clearly paid with it.
• As the payment method on the subscription is still X it will be used with the next renewal instead of Credit cards

How to reproduce this:

• Setup a website with WooCommerce, WooCommerce subscriptions and Payment plugins for Stripe (just tried this myself on a completely fresh TasteWP site)
• Setup Payment plugins for Stripe with atleast two payment methods – I’ve used credit card and Amazon pay but it shouldn’t matter which ones you choose
• Create a subscription product
• In the store, add the subscription product to the card, go to checkout and complete the purchase using Amazon Pay
• The subscription should now be created and the order paid – all is good
• Now go to the WooCommerce admin interface and go to the Subscriptions page (WooCommerce -> Subscriptions)
• Open up the newly created subscription
• On the right you have the Order actions section – select Create pending renewal order and hit Update
• Now go to the My account page in the store and to the Orders section there
• You should see the new pending order the with a Pay button – click on it
• In the checkout page that appears – select Credit card as the payment method and complete the checkout.
• The order should be paid as normal
• Now head back to the WooCommerce -> Subscriptions view. You should see that the subscription’s payment method is still registered as Amazon Pay
• Expected behaviour of course is that the payment method should have changed to Credit card

Is this something you guys can look into? Please let me know if I should provide more details!

/Carl