woocommerce_cart_needs_payment hardcoded

  • sven.vonarx

    (@svenvonarx)


    1 year, 2 months ago

    In the main plugin you are overwriting the hook woocommerce_cart_needs_payment (woocommerce-postfinancecheckout.php:572), which breaks a feature to allow orders that in some cases can be free (f.E. with coupon or free products). I personally recommend to implement a check or is there any specific reasoning for this hook at all?

Viewing 8 replies - 1 through 8 (of 8 total)
  • thibault-mambour

    (@thibaultwallee)

    1 year, 2 months ago

    hi @svenvonarx, do you think you can provide different setup / instruction on the different use case it would be required for ?

    Thank you in advance

    Thread Starter sven.vonarx

    (@svenvonarx)

    1 year, 2 months ago

    Hey @thibaultwallee
    The exact use case in our scenario would be that you use a coupon that puts the total of the cart to 0. Then the flag needs_payment should be false, since it doesn’t make sense to use any payment gateway, since there is nothing to be paid – with your hooks that set this flag to true in every case, it still would require a payment gateway. When you use TWINT for example it then fails with an error. Not sure how to explain further since it can be a use case in every shop. We tested this on a blank setup with only WordPress, WooCommerce and the PostFinance Checkout plugin.

    Thread Starter sven.vonarx

    (@svenvonarx)

    1 year, 1 month ago

    Any updates on this topic? We got another customer using your plugin (Version 3.3.7) that told us that the payment gateways show as required even if the total of the checkout order is 0. This should not be the case and goes back to the issue listed above. We would offer the technical help if needed, since this feature is a must on WooCommerce.

    Thanks in advance
    Sven

    Thread Starter sven.vonarx

    (@svenvonarx)

    1 year, 1 month ago

    FYI – It is this change that came with 3.3.5:
    https://github.com/pfpayments/woocommerce/commit/182721c9a669b8f3cea2da07f0f7961c9eb67edf#diff-946321606fed9a1c0dd2dc7162bb871793ea731521aa7e427ef71d547d9263d0R572-R590

    thibault-mambour

    (@thibaultwallee)

    1 year, 1 month ago

    hi @svenvonarx , we will try to create a ticket but maybe next time it would be better to contact PostFinance support as they should be able to help you directly (and they do not monitor closely this page)

    Thread Starter sven.vonarx

    (@svenvonarx)

    1 year, 1 month ago

    Hi @thibaultwallee, thank you for the update and for forwarding the request.

    confizz

    (@confizz)

    11 months, 3 weeks ago

    Fixed in 3.3.10

    Thread Starter sven.vonarx

    (@svenvonarx)

    11 months, 3 weeks ago

    Hi @confizz. Thanks for the update.
    I checked the changes in the GitHub repository and wondered what the benefit/thought process is, by adding a new payment method called WC_PostFinanceCheckout_Zero_Gateway instead of just allowing the Checkout to be processed without payment (which is default behaviour)?

    Best regards
    Sven

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘woocommerce_cart_needs_payment hardcoded’ is closed to new replies.