@oolongm I’m so sorry to hear this. I admit I first thought it was a quick fix, but after the first changes didn’t result in a working result I did set wp-cli up locally, fixed it and successfully tested a wp-cli activation. So I was under the impression it was fixed. It was also tested by a second tester in our team.
I just ran a local test again, the SSL activation function ran without issues.
While typing this, I realised there can be one more issue that we won’t encounter during our tests: if the tester has opened the website before wp-cli activation, the ‘site_has_ssl’ option (which is an invalid certificate safeguard) is set, and the activation completes. As during our tests, we verify a site before and after the wp cli activation, the option is set and this issue doesn’t surface. If the site is NOT opened beforehand, this option is not set, and the activation doesn’t finish. We all missed that one.
I have created a branch that includes this fix, and also some logging in case there’s something else as well: https://github.com/Really-Simple-Plugins/really-simple-ssl/tree/logging-for-wp-cli
As for the SSL menu on some sites: on multisite this is intentional (only an ssl menu on the network admin), but I take it you’re referring to regular single site setups.
A few versions before 6.0 the manage_security capability has been introduced, for a more fine grained control of who has access to the menu. After several reports of users where the capability wasn’t added to the administrator, 6.0.10 we’ve executed an additional upgrade on this capability, aimed to ensure all administrators would start out with this capability. After that I haven’t heard new reports of this issue, but if you still have issues on websites that have been upgraded to above 6.0.10 please let me know.
As for the notifications: we try to balance between upsells and offering a great free tool without too many notices. As you have been a great contributor to Really Simple SSL I certainly take your criticism on the upsells to heart and we’ll take a new look at our notifications system.
@oolongm I can confirm that what I described above is exactly what happened during our tests: if tested on an existing environment, or on a site where the back-end has been visited before activating with wp-cli, it works. This means the issue could only be reproduced if the plugin was also installed with wp-cli, and the site wasn’t visited before activating SSL.
I can also confirm our latest change fixes this. The fix will be included with the next update.
I have created a branch that includes this fix, and also some logging in case there’s something else as well: https://github.com/Really-Simple-Plugins/really-simple-ssl/tree/logging-for-wp-cli
@rogierlankhorst I can confirm the ssl activation works again on this branch. Thanks a lot for finally fixing this. I’m looking forward to have this released, so our custom wp installation routine will succeed again.
As for the notifications: we try to balance between upsells and offering a great free tool without too many notices.
I understand that you need to make some money too, maybe I was a little too harsh with my criticism out of frustration with the wp cli activation not working.
My problem with notifications may be specific to our use case, because sometimes I set up batches of 30 or more WordPress systems at once. When each installation brings 5 notifications that need to be dealt with, you can perhaps understand how annoying they become.
Now, one could argue that we should just buy the Pro version (assuming that the notifications will go away in this case), but unfortunately we already have another plugin with similar security features in use, so we don’t really need it.
Maybe you could consider a wp cli action to disable notifications for power users. If not, I guess we just start living with them, just like the other hundred notifications we see from other plugins :p
Anyway, although the code changes took several attempts to fix the problem, I am very pleased with the response times of your support and the detailed explanations you gave. That’s why I changed the rating to 4 stars. I will also gladly change the rating to 5 stars another time if you do find a solution to our notification problem 😉
