WPML compatible

  • Resolved christian70

    (@christian70)


    4 years, 1 month ago

    Hi,
    another thing that I’d strongly suggest on your brilliant plugin is make it fully compatible with WPML. Now it seems it is not, and this is bad for multi-language sites (most of all nowadays). It should be possible to translate all strings showing on the banner according to the current language.

    Thanks.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author christophrado

    (@christophrado)

    4 years, 1 month ago

    Which strings do you see as missing? I’ve just checked with Polylang and all the text inputs show up there. Polylang and WPML use the same config file, so I’d be surprised if this leads to different behaviour.

    The text strings that currently should show up for translation are defined in the WPML config file.

    Thread Starter christian70

    (@christian70)

    4 years, 1 month ago

    Well, all strings are not translated at all. I mean: they appear ready for translation in the WPML backend, but in the frontend they do not change according to the current language. The text strings I write in the plugin settings are stuck in the banner no matter what language I use. Quite weird.

    Plugin Author christophrado

    (@christophrado)

    4 years, 1 month ago

    Weird, it’s working fine for me. I’m just testing with Polylang though. I would have thought it works in WPML as well then (since it’s really set up in the same way, just the config file).

    I’ll spin up a test site with WPML later and give it a go.

    Plugin Author christophrado

    (@christophrado)

    4 years, 1 month ago

    I think I figured this one out. WPML seems to be loading itself in the plugins_loaded hook with the default priority of 10. This is where CNC is loading its settings as well, so WPML didn’t get the chance to filter the strings.

    Can you please try changing line 17 of class-cnc-settings.php to this:

    add_action( 'plugins_loaded', array( $this, 'load_options' ), 15 );

    so it says 15 at the end, and let me know if this fixes it for you?

    If so, I’ll push out an update later.

    Thread Starter christian70

    (@christian70)

    4 years, 1 month ago

    Yes man! Now it works perfectly.
    Thanks a lot.

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘WPML compatible’ is closed to new replies.