Wrong text domain

  • Resolved Matthias Kittsteiner

    (@kittmedia)


    4 years, 3 months ago

    Hi there,

    the text domain added to the plugin header differs from the one used inside the plugin.

    Plugin header says:

    Text Domain: widget-google-reviews

    However, all available translation functions use grw as text domain. This results in non-working translations if they come from translate.ww.wp.xz.cn, since these files are generated for the text domain widget-google-reviews. One would be forced to manually rename these files to the text domain grw to get it working.

    So please, correct one of them. 🙂

    Best regards,
    Matthias

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Daniel K.

    (@richplugins)

    4 years, 2 months ago

    Hi @kittmedia,

    Sorry for a late reply, sure, we will fix it in the next version!

    Thanks!

    Plugin Author Daniel K.

    (@richplugins)

    4 years, 2 months ago

    Hi @kittmedia,

    It’s fixed in the latest release 2.1.5.

    Thanks!

    Crescendo

    (@crescendoweb)

    4 years, 2 months ago

    Hi guys,
    issue is still present. With latest release, my custom Italian translation doesn’t work anymore. Some string use ‘widget-google-reviews’ as text domain.

    For example in file class-view.php on row 263:

    $this->grw_anchor($reviews_link, ‘wp-google-url’, __(‘See All Reviews’, ‘widget-google-reviews’), $options->open_link, $options->nofollow_link)

    Thread Starter Matthias Kittsteiner

    (@kittmedia)

    4 years, 2 months ago

    This is the current and correct text domain. So I don’t see any problem here. If you mean “custom” translation, did you add it by yourself via PO/MO files? Then you have to adjust its filenames to match the new and correct text domain widget-google-reviews.

    The text domain grw is gone.

    Crescendo

    (@crescendoweb)

    4 years, 2 months ago

    Your PO/MO files still uses grw text domain… I tried to use both widget-google-reviews and grw as filenames, and it’s not working. 🙂

    Crescendo

    (@crescendoweb)

    4 years, 2 months ago

    Maybe this could help, in file class-plugin.php on row 107:

    public function init_language() {
    load_plugin_textdomain(‘grw’, false, basename(dirname(GRW_PLUGIN_FILE)) . ‘/languages’);
    }

    Plugin Author Daniel K.

    (@richplugins)

    4 years, 2 months ago

    Hi @crescendoweb,

    >… load_plugin_textdomain(‘grw’, false, basename(dirname(GRW_PLUGIN_FILE)) …

    You’re absolutely correct, missed it, ok, will fix in the next release.

    Thanks!

    Crescendo

    (@crescendoweb)

    4 years, 2 months ago

    Thank you @richplugins!

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Wrong text domain’ is closed to new replies.