acmdesigns

A simple fix for the code in Nivo Lightbox would be:

o.match(/\.(jpeg|jpg|gif|png)(\?.*)?$/i)

Which would match an image URL with or without query string parameters.

I also thought maybe it was allowing room for the sidebar, but that’s not the case. It wasn’t showing the sidebar and when I enabled it, it made it smaller to accommodate the sidebar and still left an empty space where the 3rd column should be.

Ah ok, I didn’t know there was a shortcode attribute sm_category_name — had to dig through your code, because it wasn’t being set in the shortcode field. There seems to be a bug in your plugin.

In class.siple.masonry.admin.php line 156-162, the sm_category_name attribute only gets set if the $sm_post_type and $sm_as_gallery is set. This means if you have Use as Masonry Layout Gallery disabled, it will never add category the attribute to shortcode in the admin UI. I had to manually add the attribute in my shortcode and it started filtering by the category I specified.

I don’t see any other place in your code where sm_category_name is set.

Original code Line 156-162:

if ($sm_post_type && $sm_as_gallery) {
    $shortcode_atts['gallery'] = 'yes';

    if ($sm_category !== 'none') {
        $shortcode_atts['sm_category_name'] = $sm_category;
    }
}

Updated code:

if ($sm_as_gallery) {
    $shortcode_atts['gallery'] = 'yes';
}

if ($sm_post_type && $sm_category !== 'none') {
    $shortcode_atts['sm_category_name'] = $sm_category;
}

On an unrelated note, I’m not sure if I’m doing something wrong here, or it’s a conflict with my theme CSS, but It’s only showing 2 columns with a lot of space on the right instead of 3. I assume it’s either some configuration that I missed or some CSS or HTML that’s causing it to push the 3rd column down to the next row. Maybe it’s not wide enough. I’ve been digging through the HTML and CSS for a bit and haven’t found anything yet. Any suggestions?

View post on imgur.com

• This reply was modified 2 years, 8 months ago by acmdesigns.

After some investigation, I found that the JS code on line 108 of AnimOnScroll.js is never run: if( inViewport( el ) ) { ... } Looking at that function, it checks if the element is in view, and if so, it adds the .shown class to the div which turns the opacity to 1.

I noticed that it’s because the check for Modernizr.cssanimations returns undefined for some reason. I have no idea why, as this would be browser specific and I’m using Chrome v116 (I’m going to test updating to the latest CHrome, but I don’t think it’ll help)

I double checked and Modernizr is correctly loaded — Modernizr.csstransitions is true, so I’m really not sure what to make of this.

Thanks. This was exactly what I needed and it works beautifully. Is there any documentation for this or other development-related help on the site?

Thanks that worked. I also needed to add dlm_manage_logs capability to allow the Shop Manager to see the Logs page in Download Monitor.