andrei0x309
Forum Replies Created
-
Yeah, I guess is hardcoded here in JS: https://github.com/Automattic/jetpack/blob/ba2dd6c30be137baad96aafb2466d0aed7e182e5/projects/plugins/jetpack/extensions/shared/plan-upgrade-notification.js#L34-L36
Also, on the page
https://cloud.jetpack.com/pricing/BLOG_URL?site=BLOG_URL&source=jetpack-connect-planswhere you will arrive after the plugin setupwp-adminit is hard-code on the free plan button, maybe it would be a good idea to transfer the admin URI too likehttps://cloud.jetpack.com/pricing/BLOG_URL?site=BLOG_URL&admin_url=custom-fragment&source=jetpack-connect-plansAnyway, that’s only a wrong redirect, and after some digging, I don’t think custom admin_url causes a problem with the jetpack connection.
And I found why the connection with the jetpack doesn’t work in my case, it is because I used a WP instance with a custom port (8443) it seems the jetpack connection only works with non-custom ports.
Maybe you should add on https://jetpack.com/support/getting-started-with-jetpack/fixing-jetpack-connection-issues/ that a custom port is not supported.
I tested with a clean WP 5.7 instance only with the jetpack plugin and it seems if the instance has a custom port the jetpack connection won’t work.
Thanks.
Forum: Plugins
In reply to: [AddToAny Share Buttons] Suggestion – Add Support For print on AMP@micropat
Great thanks for the change.Forum: Plugins
In reply to: [AMP] import/pass functions between amp-script componentsI am not sure that localStorage is an improvement over using AMP-state.
So I guess I’ll stick
setState()/getState(), in theory, exploitingexportFunction(n,f)from the AMP flavor of WorkerDom should work somehow but I couldn’t manage to make a working example, anyway, I saw on GitHub somewhat related issues like worker-dom issue 1017 and worker-dom issue 839 so I’ll wait maybe something better will come up.On my NON-AMP template, I had a simple custom WP-REST/FETCH commenting system that also integrated default WP
comment-reply.jsI saw a git-pull on amp-wp amp-wp pull 4674 trying to useamp-scriptforcomment-reply.js, I’ll try too to see if I can get anywhere withamp-scriptfor my commenting system.Thanks again for the plugin and the help.
Forum: Plugins
In reply to: [AMP] import/pass functions between amp-script components@shetheliving Done.
Forum: Plugins
In reply to: [AMP] import/pass functions between amp-script componentsYes, you’re right, I tested it was stripped out due to invalid JSON.
Thanks.Forum: Plugins
In reply to: [AMP] Exclude specific selectors from tree shakingThanks for sharing the link, yeah for my case the second method produces less overhead.
I’ll go ahead and mark it as resolved thanks for your support.
Forum: Plugins
In reply to: [AMP] Exclude specific selectors from tree shakingThanks a lot, I should have found this solution, that’s great.
Since I am using Transitional Mode this means I will have to embed a different style for AMP since in non-AMP I do not have a parent amp-script element, that’s not a big deal since the theme already checks a lot if is in AMP or not in AMP mode.