Andrew Nevins
Forum Replies Created
-
An update for issue #2.
I understand what’s going on now. The underlying issue is due to a somewhat incorrect implementation of the
<label>element.While the
<label>element is meant to programmatically associate labels with form fields, it’s intended for visible labels.In addition, something I hadn’t spotted earlier but is also problematic, the
<label>has atabindex="0"attribute. That’s not right or needed because the<label>interaction is redundant. The only interaction a keyboard user should experience in the context of a form control is on the control itself.Considering this, I recommend two options:
Option A: remove the<label>and usearia-labelledbywith the pre-existing category text.Option B: If that isn’t possible, remove the
tabindex="0"attribute on the<label>and then replacedisplay: noneCSS styles on the inner contents of the<label>withvisually-hiddenstyles.
Option B HTML example<label for="..."> <span> ... </span> </label>Option B CSS example:
.cmplz-cookiebanner .cmplz-categories .cmplz-category .cmplz-category-header .cmplz-banner-checkbox label > span {
clip-path: inset(50%);
height: 1px;
overflow: hidden;
position: absolute;
white-space: nowrap;
width: 1px;
}- This reply was modified 10 months ago by Andrew Nevins.
I’ve re-reviewed issue #1 in light of this being a modal dialog, and I don’t think it’s much of an issue.
It’s true that it should be a HTML heading, but the modal dialog is already named by the same text via
aria-labelledby. This does the job of summarising the content for screen reader users.In addition, their heading navigation shortcut isn’t that applicable here, as the only content available is one section inside of a modal dialog. There is no other content to skip over.
However, issue #2 is something real and quite important. It’s going to make using the main purpose of the plugin difficult for some people with disabilities.
- This reply was modified 10 months ago by Andrew Nevins.
- This reply was modified 10 months ago by Andrew Nevins.
Forum: Reviews
In reply to: [APG Google Image Sitemap Feed] Sitemap can be read, but has errorsLet’s move this to a support topic: https://ww.wp.xz.cn/support/plugin/google-image-sitemap-feed-with-multisite-support/#new-post
Forum: Fixing WordPress
In reply to: how find code in templateI recommend talking to your theme author about how best to modify their theme so that your changes don’t get erased when the theme updates.
You can use this plugin to find out the files; https://ww.wp.xz.cn/plugins/what-the-file/
Forum: Fixing WordPress
In reply to: hacker send email via my admin-ajax.phpIt’s likely the hacker has left a backdoor in your site and trying to resolve this from a code level is futile:
* http://ottopress.com/2009/hacked-wordpress-backdoors/
* https://ww.wp.xz.cn/support/article/faq-my-site-was-hacked/- This reply was modified 6 years, 8 months ago by Andrew Nevins.
The link @sterndata is:
https://l.instagram.com/?u=http%3A%2F%2Fwww.nikagrizila.com%2F&e=ATO0xP6TXfBBGovn8sCswA_umBdRgLPlJaQcHhylA4_tD_eoZxM5rU9FWgnAHaz3p1z3S73kIal7vqhBForum: Fixing WordPress
In reply to: Cannot locate css/php file as highlighted by inspect element@alaninthecity, Unfortunately you’re not allowed to give admin access and others aren’t allowed to solicit that from you, nor are they allowed to solicit private information. The limitation of asking for help on these forums is that support remains here.
@zorem This review has been reviewed by at least two moderators now and we don’t see a reason to intervene. You can find us on the #forums channel on Slack: https://make.ww.wp.xz.cn/chat/
It’s likely that your website has been compromised.
If it has, try this article; https://ww.wp.xz.cn/support/article/faq-my-site-was-hacked/
- This reply was modified 6 years, 8 months ago by Andrew Nevins.
Forum: Fixing WordPress
In reply to: how to remove extern JS from sourceYou’ll need to get in touch with the plugins that implement the specific scripts. If none do then you’ll need to contact the theme author about it.
Forum: Fixing WordPress
In reply to: how to Simultaneous linking?Hmm it might be easier for you to combine those images together in an image editing tool and then upload and insert them
It may be that the close button does not work, it may not be due to your plugin but the user will not be aware of that. They will only see the issue as if it was your plugin. Using the “rate it” text to close the review looks like it has caused a negative experience.
Forum: Everything else WordPress
In reply to: Can’t Unsubscribe From PluginYou have subscribed to many topics and you have subscribed to the plugin itself.
You can view all of these subscriptions from your profile page: https://ww.wp.xz.cn/support/users/claytonchase/subscriptions/
Click on each link that you want to unsubscribe and find a button called “Unsubscribe …”
Forum: Fixing WordPress
In reply to: Stop WordPress compressing images? – Quality is terribleI think I am misunderstanding the issue. The page you’ve linked above is not demonstrating the issue then; where would I be able to see the problem?
Forum: Fixing WordPress
In reply to: Stop WordPress compressing images? – Quality is terribleFor instance this is one of the huge images that is being loaded directly on the page you’ve linked: https://www.jamieknop.com/wp-content/uploads/2019/09/product-photography-1.jpg
It’s not being resized. If it were then the file name would be named differently.