belg4mit
Forum Replies Created
-
Forum: Plugins
In reply to: [Link Library] Conditional element decorations in advanced settingsConsistency is good, but so is flexibility. Many probably use the unordered list output rather than the table output, so classed spans around the elements (name the same as the section) could work for that… just a thought.
Thanks for the great plugin!
Forum: Plugins
In reply to: [Link Library] Thumbnail priorirty setting ignored?Thanks!
Forum: Plugins
In reply to: [Autoptimize] defer loading of javascriptA small update with regards to defer; defer on scripts that are at the end of the HTML (as Autoptimize’s, by default) does not have any effect, cfr. this discussion on the HTML5 boilerplate development forum (hixie being Ian Hickson, the HTML5 spec lead).
Would it be possible to break the defer attribute out into a separate option? I like the script in the footer, but with defer various page elements do not get rendered on first load. I’d have to exclude/noptimize many jQuery components in order to get it to work, but then I lose the advantage of having all the code bundled at the end.
No problem.
Even if you cannot replicate, the patch or something fixes it for some and does not hurt anything. In fact, it’s probably better to check if the sticky option is empty and avoid hitting the database unnecessarily when it is 😉 (The second/original test for emptiness is probably overkill)
It was the sticky setting, but not because there were sticky posts, rather Subscribe2 was sending a query with an empty post__in condition and the result was extraneous posts being merged into the digest. Here’s a patch that fixes it:
--- class-s2-core.php~ 2013-10-17 15:39:29.900675197 -0500 +++ class-s2-core.php 2013-10-18 10:52:31.793602618 -0500 @@ -1454,9 +1454,11 @@ // Collect sticky posts if desired if ( $this->subscribe2_options['stickies'] == 'yes' ) { - $stickies = get_posts(array('post__in' => get_option('sticky_posts'))); - if ( !empty($stickies) ) { - $posts = array_merge((array)$stickies, (array)$posts); + $stickIDs = get_option('sticky_posts'); + if ( !empty($stickIDs) ) { + $stickies = get_posts(array('post__in' => $stickIDs)); + if ( !empty($stickies) ) + $posts = array_merge((array)$stickies, (array)$posts); } }Things worked fine until the 3.6.1 update.
The option is enabled because sometimes there are sticky posts, sometimes there are not. Currently there are not, therefore sticky posts are not the old ones that are being shown.
My s2_digest_email filter is not doing this
function rebase_digest($message){ return str_replace("http://", "https://", $message); } add_filter('s2_digest_email', 'rebase_digest');The old posts have not had their timestamps updated. Something with a revision of 26 September, 2013 @ 11:21:51 was included in a weekly digest on 10/18.
I only have one plugin that modifies queries (PressPermit), and the problem persists whether or not it is activated.
But there are no sticky posts…
option_id option_name option_value autoload 88 sticky_posts a:0:{} yesFollowing this best practice might prevent insanely repetitive processes slowing down the server and clogging up the database. The plugin ran 130 filesystem modification checks in 85 minutes, and this is not abnormal. Thankfully, it has for some reasons stopped sending email notifications.
Time Added Deleted Modified Memory Used 2013-10-06, 4:32 PM 0 0 0 22.26 MB 2013-10-06, 4:32 PM 0 0 0 22.26 MB 2013-10-06, 4:32 PM 0 0 0 22.26 MB 2013-10-06, 4:32 PM 0 0 0 22.27 MB 2013-10-06, 4:32 PM 0 0 0 22.26 MB 2013-10-06, 4:31 PM 0 0 0 22.26 MB 2013-10-06, 4:31 PM 0 0 0 22.27 MB 2013-10-06, 4:31 PM 0 0 0 22.26 MB 2013-10-06, 4:31 PM 0 0 0 22.27 MB 2013-10-06, 4:31 PM 0 0 0 22.27 MB 2013-10-06, 4:31 PM 0 0 0 22.26 MB 2013-10-06, 4:30 PM 0 0 0 22.27 MB 2013-10-06, 4:30 PM 0 0 0 22.26 MB 2013-10-06, 4:30 PM 0 0 0 22.26 MB 2013-10-06, 4:30 PM 0 0 0 22.26 MB 2013-10-06, 4:30 PM 0 0 0 22.26 MB 2013-10-06, 4:29 PM 0 0 0 22.27 MB 2013-10-06, 4:29 PM 0 0 0 22.26 MB 2013-10-06, 4:29 PM 0 0 0 22.26 MB 2013-10-06, 4:29 PM 0 0 0 22.27 MB 2013-10-06, 4:29 PM 0 0 0 22.26 MB 2013-10-06, 4:29 PM 0 0 0 22.27 MB 2013-10-06, 4:26 PM 0 0 0 22.27 MB 2013-10-06, 4:26 PM 0 0 0 22.27 MB 2013-10-06, 4:26 PM 0 0 0 22.27 MB 2013-10-06, 4:26 PM 0 0 0 22.27 MB 2013-10-06, 4:26 PM 0 0 0 22.27 MB 2013-10-06, 4:25 PM 0 0 0 22.26 MB 2013-10-06, 4:25 PM 0 0 0 22.27 MB 2013-10-06, 4:20 PM 0 0 0 22.27 MB 2013-10-06, 4:20 PM 0 0 0 22.27 MB 2013-10-06, 4:19 PM 0 0 0 22.27 MB 2013-10-06, 4:19 PM 0 0 0 22.27 MB 2013-10-06, 4:19 PM 0 0 0 22.27 MB 2013-10-06, 4:18 PM 0 0 0 22.26 MB 2013-10-06, 4:17 PM 0 0 0 22.27 MB 2013-10-06, 4:17 PM 0 0 0 22.26 MB 2013-10-06, 4:17 PM 0 0 0 22.26 MB 2013-10-06, 4:15 PM 0 0 0 22.27 MB 2013-10-06, 4:14 PM 0 0 0 22.27 MB 2013-10-06, 4:14 PM 0 0 0 22.26 MB 2013-10-06, 4:14 PM 0 0 0 22.26 MB 2013-10-06, 4:14 PM 0 0 0 22.27 MB 2013-10-06, 4:13 PM 0 0 0 22.26 MB 2013-10-06, 4:13 PM 0 0 0 22.27 MB 2013-10-06, 4:13 PM 0 0 0 22.27 MB 2013-10-06, 4:13 PM 0 0 0 22.26 MB 2013-10-06, 4:13 PM 0 0 0 22.27 MB 2013-10-06, 4:12 PM 0 0 0 22.27 MB 2013-10-06, 4:12 PM 0 0 0 22.27 MB 2013-10-06, 4:12 PM 0 0 0 22.27 MB 2013-10-06, 4:12 PM 0 0 0 22.27 MB 2013-10-06, 4:12 PM 0 0 0 22.27 MB 2013-10-06, 4:11 PM 0 0 0 22.27 MB 2013-10-06, 4:11 PM 0 0 0 22.27 MB 2013-10-06, 4:11 PM 0 0 0 22.26 MB 2013-10-06, 4:11 PM 0 0 0 22.27 MB 2013-10-06, 4:11 PM 0 0 0 22.27 MB 2013-10-06, 4:11 PM 0 0 0 22.27 MB 2013-10-06, 4:11 PM 0 0 0 22.27 MB 2013-10-06, 4:11 PM 0 0 0 22.27 MB 2013-10-06, 4:10 PM 0 0 0 22.27 MB 2013-10-06, 4:10 PM 0 0 0 22.27 MB 2013-10-06, 4:10 PM 0 0 0 22.27 MB 2013-10-06, 4:10 PM 0 0 0 22.27 MB 2013-10-06, 4:10 PM 0 0 0 22.27 MB 2013-10-06, 4:10 PM 0 0 0 22.27 MB 2013-10-06, 4:10 PM 0 0 0 22.27 MB 2013-10-06, 4:10 PM 0 0 0 22.27 MB 2013-10-06, 4:08 PM 0 0 0 22.26 MB 2013-10-06, 4:08 PM 0 0 0 22.26 MB 2013-10-06, 4:08 PM 0 0 0 22.26 MB 2013-10-06, 4:07 PM 0 0 0 22.27 MB 2013-10-06, 4:07 PM 0 0 0 22.27 MB 2013-10-06, 4:07 PM 0 0 0 22.26 MB 2013-10-06, 4:03 PM 0 0 0 22.27 MB 2013-10-06, 4:02 PM 0 0 0 22.27 MB 2013-10-06, 4:02 PM 0 0 0 22.27 MB 2013-10-06, 4:00 PM 0 0 0 22.27 MB 2013-10-06, 4:00 PM 0 0 0 22.27 MB 2013-10-06, 4:00 PM 0 0 0 22.27 MB 2013-10-06, 4:00 PM 0 0 0 22.27 MB 2013-10-06, 3:58 PM 0 0 0 22.27 MB 2013-10-06, 3:57 PM 0 0 0 22.27 MB 2013-10-06, 3:51 PM 0 0 0 22.27 MB 2013-10-06, 3:50 PM 0 0 0 22.27 MB 2013-10-06, 3:48 PM 0 0 0 22.26 MB 2013-10-06, 3:48 PM 0 0 0 22.27 MB 2013-10-06, 3:48 PM 0 0 0 22.27 MB 2013-10-06, 3:47 PM 0 0 0 22.27 MB 2013-10-06, 3:42 PM 0 0 0 22.27 MB 2013-10-06, 3:38 PM 0 0 0 22.27 MB 2013-10-06, 3:34 PM 0 0 0 22.27 MB 2013-10-06, 3:29 PM 0 0 0 22.27 MB 2013-10-06, 3:25 PM 0 0 0 22.26 MB 2013-10-06, 3:25 PM 0 0 0 22.26 MB 2013-10-06, 3:24 PM 0 0 0 22.27 MB 2013-10-06, 3:24 PM 0 0 0 22.27 MB 2013-10-06, 3:24 PM 0 0 0 22.27 MB 2013-10-06, 3:22 PM 0 0 0 22.26 MB 2013-10-06, 3:22 PM 0 0 0 22.26 MB 2013-10-06, 3:22 PM 0 0 0 22.26 MB 2013-10-06, 3:22 PM 0 0 0 22.26 MB 2013-10-06, 3:22 PM 0 0 0 22.26 MB 2013-10-06, 3:22 PM 0 0 0 22.26 MB 2013-10-06, 3:21 PM 0 0 0 22.27 MB 2013-10-06, 3:18 PM 0 0 0 22.27 MB 2013-10-06, 3:18 PM 0 0 0 22.27 MB 2013-10-06, 3:18 PM 0 0 0 22.26 MB 2013-10-06, 3:18 PM 0 0 0 22.26 MB 2013-10-06, 3:18 PM 0 0 0 22.27 MB 2013-10-06, 3:18 PM 0 0 0 22.27 MB 2013-10-06, 3:18 PM 0 0 0 22.27 MB 2013-10-06, 3:18 PM 0 0 0 22.27 MB 2013-10-06, 3:18 PM 0 0 0 22.27 MB 2013-10-06, 3:18 PM 0 0 0 22.26 MB 2013-10-06, 3:17 PM 0 0 0 22.27 MB 2013-10-06, 3:17 PM 0 0 0 22.27 MB 2013-10-06, 3:17 PM 0 0 0 22.26 MB 2013-10-06, 3:17 PM 0 0 0 22.26 MB 2013-10-06, 3:17 PM 0 0 0 22.27 MB 2013-10-06, 3:17 PM 0 0 0 22.26 MB 2013-10-06, 3:16 PM 0 0 0 22.26 MB 2013-10-06, 3:14 PM 0 0 0 22.26 MB 2013-10-06, 3:14 PM 0 0 0 22.26 MB 2013-10-06, 3:08 PM 0 0 0 22.26 MB 2013-10-06, 3:08 PM 0 0 0 22.27 MB 2013-10-06, 3:07 PM 0 0 0 22.27 MB 2013-10-06, 3:07 PM 0 0 0 22.27 MBUnfortunately I am still getting a digest at every cron invocation for many invocations after the digest is first sent. And only the first digest has fresh content, the others only contain current sticky posts. The cron entry in wp_options does not contain multiple s2_digest_cron entries either…
The “complete” digest also included posts that are weeks old, and had been reported on in a previous digest.
Forum: Plugins
In reply to: [WP Crontrol] Incorrect time in CrontrolI just discovered this as well. This patch fixes it, the code is doing an unnecessary duplicate application of the GMT offset.
--- wp-crontrol.php~ 2013-08-28 09:02:10.000000000 -0500 +++ wp-crontrol.php 2013-09-05 15:44:35.000000000 -0500 @@ -632,7 +632,7 @@ echo "<tr id=\"cron-{$id}\" class=\"{$class}\">"; echo "<td>".($event->hook=='crontrol_cron_job' ? __('<i>PHP Cron</i>', 'crontrol') : $event->hook)."</td>"; echo "<td>".($event->hook=='crontrol_cron_job' ? __('<i>PHP Code</i>', 'crontrol') : json_encode($event->args))."</td>"; - echo "<td>".get_date_from_gmt(date('Y-m-d H:i:s',$event->time),$time_format)." (".$this->time_since(time(), $event->time).")</td>"; + echo "<td>".date('Y-m-d H:i:s',$event->time)." (".$this->time_since(time(), $event->time).")</td>"; echo "<td>".($event->schedule ? $this->interval($event->interval) : __('Non-repeating', 'crontrol'))."</td>"; echo "<td><a class='view' href='tools.php?page=crontrol_admin_manage_page&action=edit-cron&id={$event->hook}&sig={$event->sig}&next_run={$event->time}#crontrol_form'>Edit</a></td>"; echo "<td><a class='view' href='".wp_nonce_url("tools.php?page=crontrol_admin_manage_page&action=run-cron&id={$event->hook}&sig={$event->sig}", "run-cron_{$event->hook}_{$event->sig}")."'>Run Now</a></td>";Yes, I used crontrol to replace the lost job last week. The job clearly ran, and there is only one of them.
Nothing has been explictly changed in my server settings, only an upgrade to WP3.6 and update to Subscribe2 about two weeks ago.
The alternate cron does not sound like a good idea i.e; not guaranteed, and meant as a fallback when things aren’t running at all.
Forum: Plugins
In reply to: [Use Google Libraries] Incompatible with 3.6?Actually, even more generic is
//ajax.googleapis.com/
for both JS and CSS exclusion. This is necessary because WP-Minify does not recognize URIs beginning with // as remote.Hi, I think you misunderstand. The pseudo-tabbed settings interface is fine. I’m a long time user of the plugin and suddenly this week’s digest was not delivered. I was willing to chalk that up to a mail fluke, and went to use the resend button. It was not there, and I attributed this to the recent settings page redesign (I’ve not needed the feature in some time), particularly given the section about resending in the FAQ.
The FAQ section should probably be removed, and it might be better to always show the resend button, but to give it a disabled attribute if it is not applicable.
Hmm, it seems the cron job got removed somehow. After changing the frequency setting the button reappeared. I took some screenshots of the interface (and crontrol) before doing so, if you are interested.
Forum: Plugins
In reply to: [Use Google Libraries] Incompatible with 3.6?The future-proofed strong to add to “JavaScript files to exclude from minify (line delimited).” is:
//ajax.googleapis.com/ajax/libs/jqueryui/