binary-organic
Forum Replies Created
-
Forum: Plugins
In reply to: [Disable Automatic P Tags] Does not workSo are you saying that this plugin was still injecting paragraph tags into your content, or that you were hoping it would do more than that when you installed it? If it’s still injecting paragraph tags in some cases, It’d be great if you could provide an example so I could try to fix it.
Forum: Plugins
In reply to: [Gravity Forms + Stripe] Stripe payments stuck in test modeWe solved our problem, and it was actually completely unrelated to the plugin. We were using a hard-coded API key for Stripe somewhere. Chalk this one up to being completely our fault. Thanks for the reply!
Totally agree with the bulk of your response. I’ve updated my review above. Thanks for reaching out.
First, there’s no such thing as code that has “zero” impact on performance.
By default your plugin loads the following on all pages of my site (again, regardless of whether or not the plugin is being used on a given page:
edd-ajax.min.js
jquery-migrate.min.js (as a dependency)
jquery.js (as a dependency)
edd.min.css
inline javascript variable (for Ajax functionality)Second, it’s not a question of whether or not your plugin includes “a lot” of code. It’s simply a question of whether or not the code being included is necessary on every page. If I have 20 plugins installed that all include 2 javascript files and inject an additional bit of inline code, I’m now loading 40 JavaScript files with 20 separate chunks of inline code.
Best coding practices should dictate that you’re never loading code that isn’t being used on a given page, and that’s the only argument I’ve made here.