Benjamin Danon
Forum Replies Created
-
Forum: Plugins
In reply to: [Add Plain-Text Email] Proposed feature : preserve linksSorry, the previous code was broken due to missing escaping. It had not been fully tested.
+ // preserve links into brackets + $text = preg_replace( '@<a .*href=(?:"|\')?([^"\' ]*).*>(.*)</a>@iu', "\$2 (\$1)", $text ); + // strip all remaining HTML tags $text = strip_tags( $text );Forum: Plugins
In reply to: [Add Plain-Text Email] Proposed feature : preserve linksI updated the regex to accept double quote, single quotes or empty (space) url delimiters :
+ // preserve links into brackets + $text = preg_replace( '@<a .*href=(?:"|')?([^"' ]*).*>(.*)</a>@iu', "\$2 (\$1)", $text ); + // strip all remaining HTML tags $text = strip_tags( $text );Forum: Plugins
In reply to: [Add Plain-Text Email] Fatal errorThe fatal error is related to the parameter type added in this commit. You should remove it to fix the issue.
- public function set_plaintext_body( PHPMailer $phpmailer ) { + public function set_plaintext_body( $phpmailer ) {I use Icegram Express to send emails. I don’t know why the
$phpmailerobject is not typed asPHPMailer.Forum: Plugins
In reply to: [Enable jQuery Migrate Helper] Errors in fatal_error_handlerThis error is reported on Github too. We have to add a condition to the line 289 of wp-content/plugins/enable-jquery-migrate-helper/class-jquery-migrate-helper.php to fix it:
if ( erroredFunction === null || typeof erroredFunction !== 'object' || typeof erroredFunction[1] === "undefined" || -1 === jQueryFunctions.indexOf( erroredFunction[1] ) ) {- This reply was modified 5 years, 1 month ago by Benjamin Danon.
Forum: Reviews
In reply to: [Show Hooks] Impressed – Great toolHi Nate. I use this way to contact you as I don’t know how to do otherwise. I need help on the caching issue with Elementor and W3 Total Cache but the two topics are closed. Can you send me a mail at [email protected]? Thank you 🙂
Forum: Plugins
In reply to: [W3 Total Cache] Disable static asset requests loggingHi @vmarko,
Perfect! I didn’t know the repo was publicly available.
Thank you.Forum: Plugins
In reply to: [WP Activity Log] Allow exporting and importing of all enabled eventsThank you for your response @robert681
I understand that a transition step is necessary. I hope this new feature will be available as soon as possible.
Best Regards.
Hi Danny,
Thank you for this quick fix. I noticed that there is a variable that should not be printed on this line https://github.com/fontsplugin/plugin/commit/5bb3d1e93a50b4195fdad35f8c491d84bcdcd32b#diff-c6ee84a3d5ff093620bf344fa5b64e31R153.
Thank you for the gift! I don’t know what features the Pro version includes. There is no information about that on the plugin page and on the site. So I don’t know if I really need it 🙂
Hi Danny,
The page took longer time to load with this plugin activated. I used xdebug profling and webgrind to identify the function. I just profiled the same page with and without the plugin and then compared the two cachegrind files with webgrind.
I found the repo. This issue is at https://github.com/fontsplugin/plugin/issues/14
Forum: Plugins
In reply to: [W3 Total Cache] Ignoring dynamic file Paths with wildcard.Hi Marko.
You wrote one year ago that regex in minify exclusions would be available in the next release https://ww.wp.xz.cn/support/topic/wildards-in-minify-exclusions/ I don’t understand why it still doesn’t work.
Divi generates JS files with unpredictable unique identifiers that I need to exclude from minifying to make the site working. I need a wildcard or a regex to exclude the directory wp-content/et-cache/
Thank you.Forum: Plugins
In reply to: [Public Post Preview] Error changing status for public previewI have the same problem here. It only works by using the Classic Editor extension. It’s broken in Gutenberg.
Gioni, I saved Cerber Main Settings through the Network admin dashboard. It does not help. The error occurs.
Forum: Plugins
In reply to: [W3 Total Cache] Remove gzip specific locations in nginx configThank you for your response. Yes, I was aware of the benefit of using pre-compressed files. I didn’t found any information about this choice. I think it’s good to have the explanation in this forum.
Forum: Plugins
In reply to: [W3 Total Cache] Remove gzip specific locations in nginx configSo yes, I missed rewrite rules that use gzip locations but don’t you think that the gzip_static nginx module should do the same thing faster?