bverhoeven

Hi @webtoffeesupport,

Thanks your response.

Apologies, the issue as described earlier does exist, but its severity is a lot lower than it initially turned out to be. Renewing subscriptions is possible, and is not directly impeded.

The original issue, that prevented renewals from working at all, was caused by an unrelated plugin in my development setup that was catching all PHP warnings and rethrowing them as ErrorException. This also affected the deprecation warning caused by the wcs_renewal_order_meta_query hook.

I’d still love to get the deprecation warning fixed. I can still reproduce the issue with WP_DEBUG_DISPLAY enabled, in which case a manual renewal shows the following deprecation notice, and prevents the redirect from happening:

Deprecated: Hook wcs_renewal_order_meta_query is <strong>deprecated</strong> since version subscriptions-core 2.5.0! Use wc_subscriptions_renewal_order_data instead. in /var/www/html/wp-includes/functions.php on line 5758

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/wp-includes/functions.php:5758) in /var/www/html/wp-includes/pluggable.php on line 1416

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/wp-includes/functions.php:5758) in /var/www/html/wp-includes/pluggable.php on line 1419

Please see a similar issue (with the same issue, but for a slightly different hook) that I reported for another plugin:

https://github.com/wpovernight/woocommerce-pdf-invoices-packing-slips/issues/460

And their fix:

https://github.com/wpovernight/woocommerce-pdf-invoices-packing-slips/pull/462/files

Please let me know if you can reproduce the issue by enabling WP_DEBUG_DISPLAY and triggering a manual renewal through “My Account > Subscriptions > [..] > Renew now”. If you can’t, I’d be more than happy to include more information.