Chris Van Patten
Forum Replies Created
-
Forum: Plugins
In reply to: [SV Gravity Forms Enhancer] Fatal error in PHP 7.1Looks like this:
add_action('widgets_init', function ($widget_class) use ($widget_class) { register_widget(get_class($widget_class)); });This should be written as
add_action('widgets_init', function () use ($widget_class) { register_widget(get_class($widget_class)); });I’ve seen the same behavior. In cases where
WP_CONTENT_DIRis defined, that constant should be respected as the canonical content directory path.Forum: Plugins
In reply to: [ACF Content Analysis for Yoast SEO] Image Crop Add-on brokenI’m encountering the same issue with an ACF Repeater field.
I had planned to post my own thread, but this seems like the right place to ask.
1) Yes, the screen is a bit annoying. I like the idea of doing it in the Yoast SEO context, or perhaps as an admin message that links to the about page.
2) Is there a way to disable it? I’m running a closed multisite network for a client and want to ensure that it’s never seen, because it’ll confuse users who aren’t totally sure what it all means.
As far as I can see, there’s a
seen_aboutoption that gets set here.Perhaps this could be a filterable option, so users can keep that always set to “true”? I think this is something I can submit as a pull request… so I’ll try that out 🙂
So I’m fairly confident I’ve got this figured out, although I still think there are some issues in the way Polldaddy handles this.
(To be honest though, I’m still getting a grasp on the full problem. I may be misinterpreting things. I could be totally wrong. Mea culpa if so.)
– Working with a multisite environment.
– Basically, when I set things up, the user configuring Polldaddy on one of our MS subsites had the ID of 1.
– But when we built the staging/production environments, our host (the lovely Pagely VPS service) handled it, and created the first user (a superadmin) as part of their process.
– I didn’t want to use the superadmin user they created (I’m pretty sure it’s intended to be used internally by Pagely’s team), so I left it alone and created new users for our actual users.
— Key here: I never granted the superadmin user, with the ID of 1, access to each of our multisite subsites, where we’re having the problem. Only the master site (which is empty) and network admin.
– So when Polldaddy runs the
can_edit()check, it gets down to line 5173 where it checks to see if$poll->_owner— which equals 1 — exists on the blog. In our case, it doesn’t, because I never granted the user with ID 1 access to the subsites.– So it follows that once I added that superadmin user, the full editing interface would work again…
– And it did!
I’m still not sure of the direct cause of this (in the sense that I haven’t dug too deeply to find out where
_owneris set or stored) but this is definitely the source of the problem.I’ll keep poking around to see what I can find!
I’m also noticing issues with extra
<p>tags around images with captions. I’m not using a<figure>/<figcaption>syntax though; just the standard<div>/<p>-based strucure.Forum: Plugins
In reply to: [Markdown on Save Improved] Preview is markdown text, not the converted htmlI’m encountering the same problem. Preview works fine, until a post is scheduled or published. After that, the preview breaks.
Forum: Plugins
In reply to: [Rich Text Excerpts] Editor in a metaboxAwesome! That’s great to hear. I’ve starred the plugin over on Github. Looking forward to trying out the new changes!
Thanks so much Jason. I’ll get these fixes incorporated and report back if/when it all works again.
Thanks!
Forum: Plugins
In reply to: [Rich Widget] Rich Widget error on thickboxThank you for this. I had a client very frustrated by the bug… and this solved it! Very odd that the plugin was enqueing its own thickbox code… but at least it’s a simple fix.
Cheers!
I’m also interested – I print canonical URLs manually (cleaner source/no self-closing slash because I’m HTML5-crazy like that). The ability to stop that output would be great.
Thanks!
Forum: Plugins
In reply to: [WP Super Cache] [Plugin: WP Super Cache] Delete cache button in Admin barIs there a way to remove this new admin bar link? Hooking into
wp_before_admin_bar_renderand removing it by its link ID (presumablydelete-cache?) with theremove_menufunction isn’t working as I would have expected.Thanks!
Forum: Plugins
In reply to: [Rich Text Tags] [Plugin: Rich Text Tags] No line breaks in version 1.4Filtering the content is half the battle.
If you do something like this…
function display_multiline_taxonomy_description($description) { return wpautop($description); } add_filter('pre_taxonomy_description', 'display_multiline_taxonomy_description');… you get the intended results, unless you switch over to plain text mode and then back. The editor doesn’t know to treat the line breaks as paragraph breaks.
It does preserve paragraphs on save though, and keeps them when the TinyMCE editor first loads. So for my clients (who don’t need the plain text editor) I’ve manually disabled the plain text version of the tag/category editor and called this the best stop-gap solution until the plugin author fixes the plugin once and for all… which I hope is soon.
Forum: Plugins
In reply to: [Rich Text Tags] [Plugin: Rich Text Tags] No line breaks in version 1.4I’ve looked into this a bit. It turns out the line breaks are being saved (view source and you’ll see) but they aren’t being wrapped properly with
<p>tags.If you filter the output of your descriptions with wpautop (for example,
echo wpautop( $posttag->description );) WordPress adds those<p>tags back in. However because they aren’t being saved as part of the description itself, TinyMCE ignores those line breaks when it initializes. TinyMCE only recognizes<p>or<br />line breaks (since it’s basically an HTML processor, and HTML ignores white space).Is there a way to filter the descriptions with
wpautopbefore they load in the TinyMCE editor, to preserve the linebreaks?Forum: Plugins
In reply to: [Rich Text Tags] error message in admin panelIt’s been a while… is there a fix in the pipeline?