conducivedata

Oh wow, thank you, @areoimiles! I was definitely not expecting such a quick and helpful response! I just did some testing, and it mostly works. Works enough, which is great.

The only issue I see so far is that it’s a real challenge to drop blocks into an empty Container without using the blocks List View. It’s much easier once a block is inside the Container, however it still won’t let me drop one in there when dropping in a new block.

Great! Thank you and you’re welcome.

I provided a workaround for the client, and they were happy with the fix and already disabled my admin access to the site, so I can’t get you a screenshot or the PHP version. But those things aren’t necessary anyway.

There’s a registration form with a Password field that has an empty Label. Line 2398 of class-fields.php, which is in a section of code that is used for outputting password and confirm password fields, tries to access $data[‘label’] without first verifying that the label exists. This generates the error message because there is no label set for the password field.

Now look at line 2378. You’re checking for a label before outputting said label–perfect! But you also need to check for the label before using it to output the placeholder for that confirm password input.

@cexpert Below is my modified wcpoa_send_file function. The fixes listed above were not super clear, I realize.

I just did a before and after test with a clean install of v1.0.8 of the plugin, making no other changes than the few lines in this function, and it went from broken to working.

    public function wcpoa_send_file() {
        //get filedata
        if (isset($_GET['attachment_id'])) {

            $attID = $_GET['attachment_id'];
            $theFile = wp_get_attachment_url($attID);
	        if (!$theFile) {
		        return;
	        }
	        //clean the fileurl
	        $file_url = stripslashes(trim($theFile));
	        //get filename
	        $file_name = basename($theFile);
	        //get fileextension
                $file_path = get_attached_file($attID);

	        $file_extension = pathinfo($file_name);
	        //security check
	        $fileName = strtolower($file_url);
	        //print_r($file_url);
	        $file_new_name = $file_name;
	        $content_type = "";
	        //check filetype
	        switch ($file_extension['extension']) {
		        case "png":
			        $content_type = "image/png";
			        break;
		        case "gif":
			        $content_type = "image/gif";
			        break;
		        case "tiff":
			        $content_type = "image/tiff";
			        break;
		        case "jpeg":
		        case "jpg":
			        $content_type = "image/jpg";
			        break;
		        case "pdf":
			        $content_type = "application/pdf";
			        break;
		        default:
			        $content_type = "application/force-download";
	        }

	        $content_type = apply_filters("wcpoa_content_type", $content_type, $file_extension['extension']);

	        header('Content-Description: File Transfer');
	        header('Content-Type: application/octet-stream');
	        header("Content-Type: {$content_type}");
	        header("Content-Disposition: attachment; filename={$file_new_name}");
	        header("Content-Transfer-Encoding: Binary");
	        header('Connection: Keep-Alive');
	        header('Expires: 0');
	        header("Cache-Control: no-cache, no-store, must-revalidate");
	        header('Cache-Control: pre-check=0, post-check=0, max-age=0', false);
	        header("Pragma: public");
	        header('Content-Length: ' . filesize($file_path));
//	        ob_clean();
	        flush();
	        readfile($file_url);
//	        ob_end_flush();
	        exit();
        }
    }