Daniel Iser
Forum Replies Created
-
@dgold75 – Good to know, my team said they replicated the issue so hopefully we can work out a proper fix.
@jimhill10 – Hmm that error indicates that files in your copy of the plugin were missing when installed. I assume you installed via normal methods?
If so that is strange.
@dgold75 – We haven’t quite nailed this down yet but most user had luck simply disabling gutenberg for popups (Popup Maker -> Settings).
We are looking into a fix and not quite sure why the block editor should break anything to be honest.
If we get a copy of the plugins we can try to work through it more directly. Feel free to send a copy to https://wppopupmaker.com/support/.
@autosoftbv – I’m gonna assume your issue is the same as the one for Elementor and other page builders which I just pushed a fix for, reverting to how it worked in the previous version for when to load popups.
This fixed it outright for 2 page builders we tested.
If not please provide more details via https://wppopupmaker.com/support/ so we can continue troubleshooting.
@guillemgalli – Going to assume your issue is related to the same change as the other Elementor and page builder rendering issues.
In which case this should be resolved in v1.21.3 which is available now.
If not please send us a message at https://wppopupmaker.com/support/ with the requested details above so we can continue troubleshooting for you.
@jimhill10 – Pushing a patch I think will handle it but if you can confirm manually on your end before I get it out that is all the better:
classes/Controllers/Frontend/Popups.php
Look for
add_action( 'wp_head', [ $this, 'preload_popups' ], 0 );Replace it with
add_action( 'wp_enqueue_scripts', [ $this, 'preload_popups' ], 11 );Let me know.
ahh that might explain it if the errors began occurring during upload.
if you left the plugin active while uploading, suddenly it uploads a file that requires a new file that hasn’t been uploaded yet. Now every request that hits your server throws errors til the upload finishes.
When WP core updates plugins, it does so in a bubble where no plugins are active while it does it to prevent that type of thing.
Hope that helps.
@modiphier – Sorry to hear that.
Just looking at the errors though it’s saying it couldn’t find files that are absolutely included in the plugin.
my only guess is you got a corrupted copy some how, but given nobody else has reported it with over 200k downloads of that version so far I don’t think it’s on our end. Missing Giles would cause instant errors on all of those sites as well and these forums would be packed u til we fixed it.
I’d try simply reinstalling the plugin from Plugins -> Add New -> Search for Popup Maker.
Hope that helps.
@jimhill10 but that fixed it for you? If so it’s a clue as to where we might need to look. 👀
@jimhill10 – interesting idea, what made you try that, and did it have any effect?
I’m reviewing everything that changed in the popup rendering/frontend stuff as that’s where the issue has to be coming from, but we changed very little in those areas other than reorganizing code a bit. So I’m not really sure what happened.
we are investigating and looking for a staging site we can play with to track it down. Soon as we get reliable way to replicate the issue we can figure out what is causing it exactly.
Realized my last reply didn’t clarify, the themes in
pum-install-functions.phpare inserted into the database, once that happens that file is never really used again. So changing it there won’t fix your install for example.- This reply was modified 8 months, 3 weeks ago by Daniel Iser.
Total shot in the dark but the only thing I can find that changed even remotely for popups is rest api registration and permissions on editing, try this filter to see if it for whatever reason fixes it.
add_filter( 'popup_maker/popup_post_type_args', function(
$args ) {
// Remove the capabilities array that's causing the issue
unset( $args['capabilities'] );
// Keep map_meta_cap for proper permission mapping
$args['map_meta_cap'] = true;
return $args;
}, 999 );Total shot in the dark but the only thing I can find that changed even remotely for popups is rest api registration and permissions on editing, try this filter to see if it for whatever reason fixes it.
add_filter( 'popup_maker/popup_post_type_args', function(
$args ) {
// Remove the capabilities array that's causing the issue
unset( $args['capabilities'] );
// Keep map_meta_cap for proper permission mapping
$args['map_meta_cap'] = true;
return $args;
}, 999 );@guillemgalli – Without more details we are not gonna be able to get a patch out for this today. Too many questions to really be able to narrow this down to anything specific:
- Have you tried disabling popups to detect content conflicts yet?
- Is it the elementor tabs component itself messing up, or is your [pt… inner content itself the part that goes missing? This is a neccessary distinction, narrows if its with Elementor, or the other plugin specifically.
- Do any of your popups, [pt..] shortocdes, or elementor modules specifically use logged in / logged out rules?
I’m not sure anything specifically was added that would make logged in different than logged out.
Awaiting your feedback so we can dig into this further.
PS this has been the only report of issues with Elementor we have seen, it very well could unrelated to Elementor, and only have to do with the custom shortcodes your inserting, which makes it unlikely our changes are the true cause, more likely just
@samuelng527 – Sorry to hear that.
Were you able to quickly toggle the correct ones back on again? I didn’t see any popups on the link you gave, so I’m assuming yes?
Honestly not sure how that could happen. There were no changes to the popup editor, settings, UI/UX ultimately, this was almost entirely an additive update adding CTAs, and a few other things.
Given my own tests just now didn’t replicate the issue, and this its the only report as of now, I will keep an eye out for any other reports, but I’m not sure there is anything we can try at this time.