danis039

@litetim thanks for the update. I’ve briefly tested it and although now the indicators (non-optim)/(optim) are toggled successfully (icons seem to be fixed as well), the files are not actually switched in the site.

The only way to switch the files the site displays is by using “Use Original Files” and “Use Optimized Files”.

@litetim I have disabled the cache altogether to test this.

To try to be a bit clearer, here’s the steps I’m doing.

Click any of (optim) on image below:

Notification is shown:

Image still shows the same (optm) and (optm) options, site displays WebP image:

Go to Image Optimization tab, click “Use Original Files”. Now the image shows as below and site still displays WebP image:

Click (non-optm), notification is shown:

Image still shows (non-optm), site displays WebP image:

In any case, the WebP image is always shown on the site.

Now, if I go to Image Optimization Settings and set Next-Gen Image Format from WebP to OFF, I can see the site toggles between optimized and non-optimized JPEG correctly by using the “Use Original Files” and “Use Optimized Files” buttons in the Image Optimization tab. Clicking the (optm) and (non-optm) buttons has no effect whatsoever, just like the examples above, but the site delivers the optimized or non-optimized JPEG as expected. In the case below, it’s correctly displaying the original non-optimized JPEG.

This certainly looks like a bug. No idea if this is connected somehow to the 500+ images infinite reload bug which I’m experiencing. Please note that I applied the fix you shared in order to make these tests on a local environment. I’m pretty sure this (optm)/(non-optm) functionality worked for me before, but I haven’t used it in a long time though.

Also, what should happen when I click (optm) next to WebP? Are there any non-optimized WebP versions to go back to? I assume it should just show whatever JPEG optm/non-optm version that is toggled above? Very confusing 🙂

For anyone trying to implement a similar solution, I’ve created a Clean Sheet event outcome, with Most Primary condition and abbreviation W. I’ve also updated the league table variables W to be W = Win + Clean Sheet and Pts to be Pts = Win x 3 + Draw + Clean Sheet x 3. Whenever there’s a clean sheet win I replace the event outcome Win by Clean Sheet. No further adjustments are needed 🙂

Thanks, @savvasha. The patch seems to be working fine for me 🙂

Is there a release planned?

@savvasha, thanks for your reply. There should be no need to fill that value manually. That’s why there’s this setting in SportsPress, right? The problem is that Full Time should be pre-filled when adding a new match, but instead the Full Time which is read from SportsPress settings is used only as a placeholder, meaning it won’t be saved unless you manually type it. I’m using the latest version of SportsPress.

• This reply was modified 4 years, 1 month ago by danis039.