Same thing was happening to me. I used the following code to prevent it from loading in the admin.
function my_mtsnb_force_bar_post_types() {
if( is_admin() ) {
return array();
}
return array( 'post', 'page' );
}
add_filter( 'mtsnb_force_bar_post_types', 'my_mtsnb_force_bar_post_types', 10, 3 );
I’m experiencing the same issue in 2.2.4 It looks like the ampersand encoding is being done by https://codex.ww.wp.xz.cn/Function_Reference/esc_url
I moved the escape_url call to sprintf function and it’s working again for me:
public static function sort_by_order_link( $views ) {
$class = ( get_query_var('orderby') == 'menu_order title' ) ? 'current' : '';
$query_string = remove_query_arg( array( 'orderby', 'order' ) );
if ( ! is_post_type_hierarchical( get_post_type() ) ) {
$query_string = add_query_arg( 'orderby', 'menu_order title', $query_string );
$query_string = add_query_arg( 'order', 'asc', $query_string );
}
$views['byorder'] = sprintf('<a href="%s" class="%s">%s</a>', esc_url( $query_string ), $class, __("Sort by Order", 'simple-page-ordering'));
return $views;
}