dcwarwick
Forum Replies Created
-
Forum: Plugins
In reply to: [Advanced Custom Fields: Multiple Fields per row] Row closePS, I have ACF:MFPR v1.0.5 with ACF v4.4.11 on WP 4.7.2
Forum: Plugins
In reply to: [Advanced Custom Fields: Multiple Fields per row] Row closeI think I see the problem. In ‘input.js’ line 20 you are scanning ahead for an element with the class “acf-field-row”, but the row-close field doesn’t have this class on it. Perhaps this is a recent change in ACF? I can see that the row-close field carries a class “field_type-row” — perhaps this is the new convention?
Anyhow, I updated input.js in my copy of the plugin and changed:
var content = $el.nextUntil(‘.acf-field-row’);
to
var content = $el.nextUntil(‘.field_type-row’);
and it now works fine for me.I haven’t made a pull request for this because I think it needs some more investigation to find at what version the classes were changed, and maybe make the code use the correct classes for the ACF version. But I hope this is useful.
Forum: Plugins
In reply to: [Page Specific Menu Items] Unexpected outcome when all menu items uncheckedActually, there is another page where the same problem occurs, and that is the search results page — again, all the menu items appear on that. I would have expected to get *no* menu items at all on the search results page if I’ve selected ‘hide’ as the default.
On my own system, I have edited your plugin to remove that ‘if’ test, and it seems to work fine for me. The page where I wanted no menu at all now has no menu items, as does the search results page. If there’s a particular reason why that test was included, do let me know, because I can’t test every eventuality in my site and might miss whatever it is!
Thanks. I hope this helps.
dave