diablodale
Forum Replies Created
-
Confirm deleting the ‘Activated_Akismet’ wp option prevents the UI takeover.
I appreciate the code refinement also. After it moves into a release, I will be able to verify if it works as intended.
These two possibilities facilitate pipelines for building known infrastructure/containers, automated testing of them, and deployment. 🙂
I’ve reproduced a related behavior with this page-takeover of akismet. I saw it yesterday but couldn’t reproduce it. I just now did.
Same software everywhere, just a new instance of the same.
Open chrome browser
visit WPsite/wp-admin/
enter user, password
forever 302 redirect loop by akismet (see screenshot)
chrome halts forever loopscreenshot:
https://drive.google.com/open?id=176f8xR_9y9uiKZvKaQbzb5QV0R3ZYma7Naturally, I cleared cookies. No affect, forever 302 loop still occurs.
Since this is a change in behavior yet no software change, this lends a bit more evidence that the method akismet is using the force this UI is part of a race condition and some tiny difference has occurred in this instance which is exposing this forever loop bug.So there are two related issues:
1) the takeover UI is intrusive and kills the OOBE/first-run WP experience
2) there is likely a race condition with this takeover that sometimes it kills peers like Woocommerce, and other times it gets into a forever 302 loop with itself.- This reply was modified 6 years, 7 months ago by diablodale.
We follow the approach of using containers with a known and fixed set of files; the file systems of the container are read-only when running (with a small set of specific tmpfs mounts). During build stage of the containers, specific versions of everything are included; specific WP, specific akismet, specific Woocommerce, etc. This facilitates a tested known infrastructure which can be deployed as a single unit; rolled forward as a unit, rolled back as a unit.
These containers can be connected to an empty db for a new WP install. Other times it is an existing WP db. On container spinup, we configure/migrate using wp-cli (e.g. de/activating plugins, settings, database work, etc.). Then launch apache2 as PID=1 in the foreground ready for traffic.
I’m confident you know there are UI mechanisms to call attention to config needs using non-dismissible card notices that appear on the top of the screen; they leave the main content unaltered under it. Your peers at Automattic like WooCommerce use such an approach with a card that writes “Welcome to WooCommerce – You‘re almost ready to start selling :)” with a “Run the setup wizard” action button.
Curious…your redirect is blocking this Woo setup card of your own peer. Unintended sibling fighting. 🥊 In my screenshot MonsterInsights uses the card approach…they were able to somehow still appear. I smell a race condition 🏎Sure. In the repo, there are no hits to any URL on the webserver unless I describe.
I use docker/compose to destroy/create fresh every time. I’m currently developing at home and the pipeline creates a self-signed cert for TLS on the apache2 server in a container.I open a blank tab in chrome. Type in the servername/wp-admin/ then…
/wp-admin
redirects to
/wp-login.php
I turn on chrome developer tools (disabled cache, preserve log).
I fill out form with username and password, click to submit
The html posts to /wp-login.php
immediate 302 redirect to…
/wp-admin/
immediate 302 redirect to…
/wp-admin/options-general.php?page=akismet-key-config&view=startHere is redacted screenshot https://drive.google.com/open?id=1mWgkanNrv17eH31JBVujh-W_FGBrXyU4
And the raw response header that did the immediate 302 redirect to akismet:
HTTP/1.1 302 Found
Date: Wed, 06 Nov 2019 21:18:46 GMT
Server: Apache/2.4.38
Strict-Transport-Security: max-age=63072000
Expires: Wed, 11 Jan 1984 05:00:00 GMT
Cache-Control: no-transform, no-cache, no-store, must-revalidate
X-Frame-Options: SAMEORIGIN
Location: https://home-nas/wp-admin/options-general.php?page=akismet-key-config&view=start
Referrer-Policy: strict-origin-when-cross-origin
Set-Cookie: wp-settings-1=deleted; expires=Thu, 01-Jan-1970 00:00:01 GMT; Max-Age=0; path=/; secure
Set-Cookie: wp-settings-time-1=1573075129; expires=Thu, 05-Nov-2020 21:18:49 GMT; Max-Age=31536000; path=/; secure
Keep-Alive: timeout=5, max=99
Connection: Keep-Alive
Transfer-Encoding: chunked
Content-Type: text/html; charset=UTF-8- This reply was modified 6 years, 7 months ago by diablodale.
…
- This reply was modified 6 years, 7 months ago by diablodale.
That CSS isn’t valid. Missing a curly bracket somewhere. And the overuse of !important suggests something else at the core is likely a problem.
You can see at http://hidale.com/privacy I fixed the problems in v1.5.7 by not using your theme param on the shortcode and applying a single custom CSS of:
table.cookielawinfo-classic {background:white}Just in case…when I view code of my website I see at the top two separate loads 🙁 of cookielawinfo
<link rel='stylesheet' id='cookielawinfo-style-css' href='https://hidale.com/wp-content/plugins/cookie-law-info/css/cli-style.css?ver=1.5.4' type='text/css' media='all' />
and
<link rel='stylesheet' id='cookielawinfo-table-style-css' href='https://hidale.com/wp-content/plugins/cookie-law-info/css/cli-tables.css?ver=1.5.4' type='text/css' media='all' />Natually, a single style sheet is best.
But also, notice the version is 1.5.4. Shouldn’t it be 1.5.7? Did you update the CSS between 1.5.4 and 1.5.7, yet this param is preventing the newer 1.5.7 file to be downloaded/used?This old version is also on your script
<script type='text/javascript' src='https://hidale.com/wp-content/plugins/cookie-law-info/js/cookielawinfo.js?ver=1.5.4'></script>I made tests pages for you
with [cookie_audit style=”winter”]
https://hidale.com/test-cli-plugin1/with [cookie_audit]
https://hidale.com/test-cli-plugin2/Forum: Plugins
In reply to: [Server IP & Memory Usage Display] peak memory allocated is more interestingTechnically works for me. I tested it on two servers.
Having both the instantaneous and the peak might be confusing to some users of the plugin. I recommend updating the documentation to describe the two values -or- have only the peak.
Thank you for considering my feedback 🙂
Caveat, if you have pictures or other media on a private page, then AIOSP v2.3.4.2 on WP 4.5.1 will (by default) include that media in the sitemap.
The only workaround is to deselect “media/attachments” in XML Sitemap settings for post types.
Forum: Plugins
In reply to: [Plugin: Query Posts] orderby meta_value and meta_compare problemsits due to a bug on the code. he’s trying to strip tags from the settings when they are passed back to save. The less than sign in ‘<‘ and ‘<=’ is being stripped out.
You can change line 261 in query-posts.php to the following to resolve the immediate issue:
$instance[‘meta_compare’] = $new_instance[‘meta_compare’];