efreja
Forum Replies Created
-
Forum: Plugins
In reply to: [Music Sheet Viewer] Works fine on WordPress 6.5.3 and php 8.1Thanks for the notice, I’ll update the release notes.
Forum: Plugins
In reply to: [Music Sheet Viewer] Repeat supportHello milosisd,
Thanks for your support.
No, you’re not doing anything wrong 😉
It’s just that it’s not supported as the rendering engine on which the plugin is based (Verovio) does not support it.
Actually, it is partially supported as explained here : https://github.com/rism-ch/verovio/issues/235#issuecomment-772294228 but it requires that the score is ‘expanded’ and not kept in its original condensed form.
I think that it’s not what users expect : they want to read the original score not a score that has some kind of unfolded bars.
However, when the feature is fully working in Verovio, I’ll include it in the plugin.
Thanks
Forum: Plugins
In reply to: [Music Sheet Viewer] Display on multilanguage siteHello George,
Sorry for not responding earlier but I see that you managed it yourself..
Hopefully because I had no idea on the issue…
Thanks
Forum: Plugins
In reply to: [Music Sheet Viewer] Verovio err=ReferenceError: jQuery is not defined,log=Hello akinsaylik,
Just upgraded my WP 5.9.4 version to 6.0.2 and I don’t encounter the problem.
However I don’t say there is no problem on a fresh install, but I’d like to avoid reinstalling a fresh install just for testing that.
I may apply your fix but I don’t see why a dependency would not be enough.
Can you test for me replacing line 273 of music-sheet-viewer.php by:wp_enqueue_script (‘msv’, plugins_url(‘/js/msv.js’, __FILE__ ), array(‘jquery’), self::MSV_VERSION);
to see if it also fixes your issue?
Thanks!
EtienneForum: Plugins
In reply to: [Music Sheet Viewer] Verovio err=ReferenceError: jQuery is not defined,log=Hello akinsylik,
Yes the plugin is only tested up to WP 5.9.4.
I shall test it with WP 6 as apparently, as you say, jQuery is not imported automatically by this version.
Thanks if your fix works !Forum: Plugins
In reply to: [Music Sheet Viewer] AJAX error pn_msv_ajax_url not definedHi zenframe,
As I see no answer, I guess that my answer solved your problem.
Therefore I mark it as resolved.Forum: Plugins
In reply to: [Music Sheet Viewer] AJAX error pn_msv_ajax_url not definedHi zenframe,
As far as I can see the page in question works well.
I guess it was just to point to your work.But for having the code in your example working, you should put it in a php file called each time a page or post of your website must be displayed.
I don’t know in your case but for example it could be in a custom version of the footer.php of your theme.
That will make that the pn_msv_ajax_url variable in question is added to your page when the plugin finds that it contains the pn_msv shortcode.Hope it helps.
Etienne
Forum: Plugins
In reply to: [Music Sheet Viewer] JS error “Cannot destructure property”Hello. As the block now shows up, the object of the ticket can be considered as fixed by version 4.0.2, so I mark it as resolved. If you still have issues that are caused by the plugin please open a new ticket.
Forum: Plugins
In reply to: [Music Sheet Viewer] JS error “Cannot destructure property”That’s the hic !
Wordpress is bundled with JQuery.
See :
https://codex.ww.wp.xz.cn/Javascript_Reference
There must be an installation problem or some.
Hundreds of sites use my plugin without any issue.
Hope it helps.Forum: Plugins
In reply to: [Music Sheet Viewer] Changing instrumentHello. This feature is now brought by version 4.0.2. There are 72 possible instruments. Enjoy!
Forum: Plugins
In reply to: [Music Sheet Viewer] JS error “Cannot destructure property”Hello. Please try with version 4.0.2. Thanks
Forum: Plugins
In reply to: [Music Sheet Viewer] JS error “Cannot destructure property”Hello,
I know another issue : Â Â Â Uncaught TypeError: wp.serverSideRender is undefined
in block.js.
which to my knowledge only appears in the console and neverthesess does not prevent from working.
But just in case, it is corrected in next version to come very soon…Forum: Plugins
In reply to: [Music Sheet Viewer] Please include humdrum formatHowever, I note that the need has been raised, in case it would reappear.
Forum: Plugins
In reply to: [Music Sheet Viewer] Mini-player stylingHello Malry,
No worries, you’re welcome but it’s not a question of opinion…
It’s just that the miniplayer is not standard: it’s custom, specific to the plugin.
And the progress has no background !
CheersForum: Plugins
In reply to: [Music Sheet Viewer] Mini-player stylingHello Malry,
You can’t ‘add’ an element to the miniplayer, you can just override the default syling of existing ones, I’m sorry.
Besides, I think that without background it gives a much more modern style…
Enjoy !