Rimas
Forum Replies Created
-
Forum: Plugins
In reply to: [Headers Security Advanced & HSTS WP] HSTS Header Present But Not Working@thirstyjon, yes. Try updating the plugin and checking your SecurityHeaders report. Note that they seem to cache your page for a couple minutes, so the report may not reflect your update immediately.
Hi @sandeepdixit, the plugin works with non-Apache servers as well. While it does generate an Apache-specific
.htaccessfile when saving settings, it also adds the headers on each request. With the release of 5.0.22, this now works even better, since same code is now used to generate headers for both cases.Forum: Plugins
In reply to: [Headers Security Advanced & HSTS WP] HSTS Header Present But Not WorkingAaaand, it’s now live!
Forum: Plugins
In reply to: [Headers Security Advanced & HSTS WP] HSTS Header Present But Not WorkingStatus report: I made a huge pull request to @unicorn03. At least on my server, the header now works as expected and I haven’t noticed any regressions caused by my changes.
Forum: Plugins
In reply to: [Headers Security Advanced & HSTS WP] HSTS Header Present But Not Working@thirstyjon, yes, I meant it’s a bug in the plugin. I’m now able to contribute to this plugin since yesterday evening (thanks to @unicorn03) and I plan to look into this issue since, as a user of Nginx, I’m also affected by it.
Forum: Plugins
In reply to: [Headers Security Advanced & HSTS WP] Misleading option description@unicorn03, thanks for replying! If the repo is public, could you just link it here? I’d then fork it and make a pull request or two.
Edit: my username over at Github is
rimas-kudelis. Cheers!- This reply was modified 3 years ago by Rimas.
Forum: Plugins
In reply to: [Headers Security Advanced & HSTS WP] Misleading option descriptionI also noticed some “code smell” in the code. For example, there are two distinct places where the headers that should be added are collected (and – of course – they aren’t in sync). Also, the lack of proper indentation makes the code difficult to read.
Do you have a Git repository where pull requests could be made? I know that WordPress plugins repository still uses Subversion (
svn), but I pity anyone still having to use it as their main versioning tool, so I’m thinking maybe you have a better co-working tool in place, and only mirror the result to Subversion instead?- This reply was modified 3 years ago by Rimas.
Forum: Plugins
In reply to: [Headers Security Advanced & HSTS WP] HSTS Header Present But Not Working@kennetheyoung, I would guess that the response to your
https://mysite.com/request didn’t have the HSTS header (or any other headers added by this plugin), but then the one to thehttps://www.mysite.com/request did? I think this would be perfectly normal, because the original redirect might be performed outside WordPress, or, even if not (this depends on the setup), WordPress might not be adding any custom headers (including these) due to the redirect nature of the response.Forum: Plugins
In reply to: [Headers Security Advanced & HSTS WP] HSTS Header Present But Not WorkingIt’s the same in my case, and I would guess that, just like me, you aren’t using Apache, so the
.htaccessfile simply doesn’t have any effect.Since all other headers are also sent by PHP I would classify this as a bug. Furthermore, looking at the code, I see that the function which instructs WordPress to add this HTTP header to the output is only called when the settings for this particular header are updated, which actually has no effect since the update action produces a redirect response with no custom headers whatsoever, so it’s definitely a bug.
I also noticed that this plugin adds two
<IfModule mod_headers.c>blocks in the file instead of just one: the first one only contains an instruction to add the HSTS header, and the other contains instructions for all other headers. Furthermore, the HSTS block gains an extra blank line each time these settings are saved. It would be nicer if only one such block was added and the unnecessary blank lines were not there.- This reply was modified 3 years ago by Rimas.
Forum: Plugins
In reply to: [TinyMCE Clear Float] Problems with WordPress 5.3@tyrannous my reason for the Gutenberg block was that I tried placing several “Classic HTML” blocks one after another, and to my surprise, they didn’t clear floats. Because of that I think it does make sense to introduce a clearing element as a type of block.
Forum: Plugins
In reply to: [TinyMCE Clear Float] Problems with WordPress 5.3By the way, I’d like to also suggest a new feature for this plugin: please add a “Clear Floats” block type in addition to the TinyMCE button. I don’t think a plugin that does that already exists, but it’s obviously the same functionality, so having it as part of this plugin would make perfect sense.
- This reply was modified 6 years, 4 months ago by Rimas.
Forum: Plugins
In reply to: [Sublanguage] Custom taxonomy broken after upgradeMarking resolved. Thanks again!
Forum: Plugins
In reply to: [Sublanguage] Custom taxonomy broken after upgradeAha! Now it works. Thanks a lot! 🙂
Forum: Plugins
In reply to: [Sublanguage] Custom taxonomy broken after upgradeYes, I downloaded the zip from the link you gave me and extracted it.
Forum: Plugins
In reply to: [Sublanguage] Custom taxonomy broken after upgradeShould I do something other than update the plugin? Because it seems to me like the problem is still there.