Rimas
Forum Replies Created
-
Forum: Plugins
In reply to: [The Events Calendar] Events URL not displaying page titleSorry guys, but I think I’ve narrowed the cause down already, and I don’t feel like playing with a live site just to confirm the fact that your plugin won’t work with a non-default theme properly. I mean, I fully accept the fact that this is your plugin’s incompatibility with the theme used. I could say I’m in the “Look for a solution” step already, which suggests users to post here.
When you say you don’t support non-default themes, it makes some sense, but not a lot. While some poor quality themes might be a pain to support, I don’t think you have to do something special to support well-made ones. All you have to do in this case is use WP-provided hooks/filters properly, instead of outputting headings yourselves (which quite obviously doesn’t scale well) and then hiding behind this “your theme your problem” argument.
I wanted to come up with a patch to your plugin, but it’s just too complex for me to grasp its code quickly, and I assumed it would take much less time for you to figure out where to add the necessary filters, since it’s your code anyway – you know it better than anyone.
Cheers!
Forum: Plugins
In reply to: [The Events Calendar] Events URL not displaying page titleHi Nico!
Well I’ve worked this around by changing the following piece of code in the theme:the_title();to the following:
$title = the_title('', '', false); if (empty($title) && function_exists('tribe_get_events_title')) { $title = tribe_get_events_title(); } echo $title;But I really don’t think this is what I should be doing if the plugin behaved right and hooked up to the call to
the_title()itself.Just for the reference, the theme in question is called Felynx Forest, and the page is http://daumantaskirilauskas.com/events/ .
Regards,
RimasForum: Plugins
In reply to: [The Events Calendar] Events URL not displaying page titleHi @joinof!
I’m having this issue as well, and couldn’t find anything related to this in the Themer’s Guide.Yes, I have managed to copy your templates and hide the “unwanted” heading from my copies, but to empower the theme to output them in the correct place, I believe the code of your plugin has to be extended as well, e.g. by adding a filter on ‘the_title’ in the appropriate place. Sadly, I couldn’t figure out which exact place that would be.
Forum: Fixing WordPress
In reply to: wp1.0 week in calendar always starts on SundayNot sure. Works perfectly for me so far.