Fiech

Hi Thomas,

thanks for your answer. I definitely understand the need for developers to license their products in a way fair to both parties.

The preview version works flawlessly, btw. Currently we are facing a discourse with a stock photographer and one problem might be, that without the preview version there are be certain pages (like the start page, widgets, sliders, but also category listings, etc.) where no sources are displayed on pictures.

Best,
Johannes

For what it’s worth: This shortcode is implemented as a plugin.

We use the classic editor and a custom theme based on the WP Jurist Theme.

The twitch iframe is created by a custom shortcode that creates the iframe.

Here is an excerpt surrounding the iframe if I do not have any custom provider straight from the source code:

<article id="post-3588" class="post-3588 page type-page status-publish hentry">

	<div class="entry-content post-content">
		<iframe src="https://player.twitch.tv/?channel=[CHANNEL]&parent=[DOMAIN]" width="400" height="300" allowfullscreen="false"></iframe>
			</div><!-- .entry-content -->
	
	<footer class="entry-meta">
		<span class="create-date">
			<i class="fal fa-calendar"></i> <span class="entry-date"> 2. Juni 2021</span>
		</span>
		<span class="edit-date">
			<i class="fal fa-pen"></i> <span class="update-date">2. Juni 2021</span>
		</span>
		<span class="edit-link"><a class="post-edit-link" href="[EDIT_LINK]">Bearbeiten</a></span>	</footer><!-- .entry-meta -->

	    
    <div class="post-divider"></div>
    
</article>

I don’t see any errors in the console save for two font download related ones.

If you think it’ll help, I can send you the URL via a private message of your choice.

Thank you for the information. Then I’ll wait. Maybe you even could add twitch to the defaults?

I forgot to add, that the privacy cover is disappearing when you click it, but then its just blank space behind it, no player.

Hey, first thank you for your fast response!

It’s definitely a progress. I can always go back and reemploy the additional queries for the next versions.

But if I may take up one of my points from 3 weeks ago: I know that probably a lot of work’s gone into the current way the plugin is working, but how compatible is this with, say, multi-language blogs and does this pre-calculation of the overlays really bring such an improvement in speed (trading a text replacement for a database query)? In other words, is it worth the headache this approach seems to create?

Also if one would like to use a provider’s open API to (server side) fetch additional meta data about the embedded media in the future, this would be harder to implement…

Oookkk… I think I now have a better understanding about the inner workings workings and what might be the problem…

So first, I finally solved my problem with the “epi_embed”, it’s the entry in the column “post_type” in the <prefix>_posts table.

And I think I found the problem: For some of the blogs, the migration did not complete. Instead of a embed_privacy_migrate_version option in the <blog_prefix>_options table, I only got a embed_privacy_is_migrating = 1 option.

You may remember my enhancement proposal here.

To fix this for our network, I had to add two more queries:

$query3 = "DELETE FROM ".$wpdb->get_blog_prefix($site->blog_id)."options WHERE option_name LIKE 'embed_privacy_%'";
				$wpdb->query( $query3 );
				
				$query4 = "DELETE from ".$wpdb->get_blog_prefix($site->blog_id)."posts WHERE post_type='epi_embed'";
				$wpdb->query( $query4 );

After that I disabled/enabled the plugin. Unfortunately, this did not directly create the entries in the posts-tables. Only after navigating to the dashboards of the sites, these were created. With ~300 subblogs I’d love an alternative (although over the next few days, I hope that most of the blog admins are logging in slowly creating the missing posts…

This all leads me to the question, if the posts-approach for the overlays is really needed? Without knowing most of the code, couldn’t this lead to problems with multi-language sites? Is the DB lookup really that much quicker than to either create the overlay on the fly or save it temporarily somewhere else?