himselfv
Forum Replies Created
-
Forum: Plugins
In reply to: [WordPress Social Login] A bunch of bugreportsMerge this one too, please! (I don’t see it in dev)
> Hook: let filters reliably guess existing users (similar to how it’s done by email)
> http://boku.ru/files/wsl/commit-56b8b84Here’s why it’s needed. I have a mixed OpenID/WPSL setup so say a user logs in with Google OpenID. This address is then linked with his account. Then he logins with the same address but through WP Social Login. I want to be able to figure out that it’s the same user.
For that, I wrote a plugin which hooks the “search for existing user”/”create new user”, and for certain providers either checks for associated OpenID or adds new OpenID association so that whatever way the user logs in, he ends up with the same account.
But it needs the above patch to work.
Forum: Plugins
In reply to: [WordPress Social Login] A bunch of bugreports@edl2000: Sure, http://boku.ru/files/wsl/wsl.authentication.txt although you can as well just apply patches over your file.
Forum: Plugins
In reply to: [WordPress Social Login] A bunch of bugreportsUpdated links:
This one fixed the issue:
http://boku.ru/files/wsl/commit-e786223Hook: run user data through filters before updating
http://boku.ru/files/wsl/commit-5b17842Hook: let filters reliably guess existing users (similar to how it’s done by email)
http://boku.ru/files/wsl/commit-56b8b84Fix: Do not call wsl_hook_process_login_alter_userdata twice, what if hooks do something permanent?
http://boku.ru/files/wsl/commit-5d73689Forum: Plugins
In reply to: [WordPress Social Login] A bunch of bugreportsTwo more, fixed some of “empty login” issues:
http://boku.ru/temp/fix-empty-login-names.patch
Try nicer “Last + first name” nicknames even when the login is “google_user_md5md5md5md5”:
Forum: Plugins
In reply to: [WordPress Social Login] A bunch of bugreportsAnd these too please while we’re at it!)
http://boku.ru/temp/commit-5b17842
http://boku.ru/temp/commit-56b8b84
http://boku.ru/temp/commit-5d73689(They add two hooks and fix _alter_userdata hook so it’s not called twice)
Forum: Plugins
In reply to: [WordPress Social Login] A bunch of bugreportsCouldn’t find how to commit on github so here’s a patch:
Forum: Plugins
In reply to: [WordPress Social Login] A bunch of bugreportsAlso I have no idea what to do with login generation so please you deal with it 🙂
I’ll fix the non-checking-for-errors on wp_insert_user.Forum: Plugins
In reply to: [WordPress Social Login] A bunch of bugreportsMiled, alright I’ll try but I’m new to this plugin so I might do something wrongly.
Forum: Plugins
In reply to: [WordPress Social Login] A bunch of bugreportsApparently there IS a check in wsl_process_login_create_user, but the WP_Error value is still returned as $user_id after printing out error. And wsl_process_login_reauth which uses wsl_process_login_create_user doesn’t check whether $user_id it recieves is not WP_Error by chance.