Fascinating. Alright. I’ll create a release with the option to hide the shortcut link. It will also change the URL of the dashboard itself in case that’s the issue.
Oh bother. I’m out of ideas, so I may just add a config setting to disable the dashboard shortcut link for now on affected sites.
Before I do that — can I ask — are the shortcut links on alert popups broken too? E.g. “Edit page”? Seems like if one is broken they should both be broken, but if not that might give me a lead.
Oh…the other thing that would really, really help is finding out if it is just opening the link in the new window that is the problem, since that might lose referrer information.
Do you happen to use browser developer tools? If so, if you’re up for helping, what I’m curious to know is what happens if you remove target="_blank" from the link that doesn’t work, and then click it.
Interesting. There must be a required referrer header tag from the admin side or something.
I cannot reproduce this in my environment. Could you perhaps tell me if you are running any plugins that harden security or manage routing? E.g. Pressbooks?
If I can figure out what setting or plugin is blocking the route it will be much easier for me to troubleshoot.
This is now mostly-addressed in 2.0.10 — it won’t flag it as a red-alert any more, but the manual check for links with unclear purpose (“click here”) still does not read their value right, so it goes from a false positive to a false negative. But that’s at least not annoying any more, and losing a manual check is not so big a deal.
Oh dear. Aria-label attributes should never be empty. I recommend submitting this to Spectra as a bug; they should not be setting the attribute at all if it is empty.
That said………I’m testing this markup now with NVDA and VoiceOver, and they both seem to recognize this as invalid markup and ignore the attribute, so it might not actually be a problem for accessibility. It looks like someone confirmed the same in JAWS.
I’ll have to sleep on whether I’ll add an exception to the test. In the interim you can disable checks on these links by going into the Editoria11y settings for “Do not flag these elements” and adding a selector for:
Hmmph; I’m still puzzled. I downloaded that plugin and made a bunch of blocks and buttons, and the only way I could get Editoria11y to throw a tip was if I created a real problem — e.g., assigning an aria-label of an empty space in the Kadence advanced tab:
Could I ask another favor to try to locate this problem? Would you be willing to inspect some of the marked links and send me a paste or screenshot of the markup? Then I can make sure I’m troubleshooting with the exact right tags. Or if the site is live just give me a link to a page and I’ll take a look at it myself.
E.g., for the one marked above, the code (with the bad aria-label) looks like this:
<a class="kb-button kt-button button kb-btn215_e7b705-a1 kt-btn-size-standard kt-btn-width-type-auto kb-btn-global-fill kt-btn-has-text-true kt-btn-has-svg-false wp-block-kadence-singlebtn" aria-label=" " href="https://editoria11y-wp.ddev.site/2024/11/27/hey-there/"><span class="kt-btn-inner-text">link with space in aria label</span></a>
Hmm I can’t reproduce this. Would you mind telling me what version of WordPress and what version of the plugin you are running? And if you are seeing this while editing, after saving, or both?
I’m trying to figure out if the markup might be different in a different Gutenberg version than what I’m testing in, or if there might be a configuration issue where “download”, “pdf” and “form” are getting stripped by the meaningless links test (“click here to download”) and tripping the wrong tooltip.
Troubleshooting mostly involves figuring out if it is trying to run and failing, or not trying to run.
Some things I can think of to try…
Make sure you’re on the current version. A recent version had some race conditions that led to it not always appearing.
If there’s no data or config you would be sad to lose, uninstall / reinstall to clear out the config. There are quite a few config items that can cause it not work if they contain invalid selectors.
If you are comfortable using browser developer tools in anything other than Safari, go to a page you would expect to see the module, and open the browser console:
See if there are any relevant warnings or errors.
If not, type Ed11y and press return.
If there is an “Ed11y is undefined” error, the problem is in the plugin — Editoria11y is not present on the page. Troubleshooting this remotely will be challenging; I’ll want to know things like what version of WordPress you are on and what theme you are using.
If it is there and you get something you can unfold and explore, you should see the following key/values if it is running — disabled: false, once: true, ignoreAll: false. If not, it’s not running for some reason and we should troubleshoot here. Try running Ed11y.checkAll() and see if it appears, or if errors appear in the console.
If it seems like it is running but you still can’t see it, inspect the page and look through the tags to the very end, after <footer>. You should see <ed11y-element-panel>. If that is there, then the problem is almost certainly with the theme — there might be some style in the theme that is putting something in front of Editoria11y. If you send me the URL of the site I can try to troubleshoot this one.
