jacobdg
Forum Replies Created
-
Forum: Plugins
In reply to: [AMP for WP - Accelerated Mobile Pages] Auto adds height tag to imagesResubmitting
All images with a defined width property on an image tag a height property appears get added to the amp page.Example:
Non-AMP
<img src="/example.png" width="260"/>to
AMP
<amp-img src="/example.png" width="260" height=""/>This is causing Google to report errors on amp pages for undefined height property on image tag.
Can you look into this issue?
Forum: Plugins
In reply to: [AMP for WP - Accelerated Mobile Pages] Can’t Use itemtype markup on ul tagsI saw what you were doing on github for fixing the issue so know where the issue is I came up with my own quick fix for this problem.
In themes/features.php line 920 I updated it to
$content = preg_replace(‘/<ul(.*?)( )type=”.*?”(.*?)/’,'<ul $1′,$content);
So it is looking for a space before the type tag and does change the itemtype tag.
Thank you.
I hope your update fixes this issue.
Forum: Plugins
In reply to: [AMP for WP - Accelerated Mobile Pages] Can’t Use itemtype markup on ul tagsIt is currently setup as:
<ul itemscope=”” itemtype=”http://www.schema.org/SiteNavigationElement” class=”something”>and AMP turns it into:
<ul itemscope item class=”something”>Forum: Plugins
In reply to: [AMP for WP - Accelerated Mobile Pages] Can’t Use itemtype markup on ul tagsSorry @frenchomatic
That solution doesn’t fix the issue.
The issue is that ul tags are having markup changed from the code.
Forum: Plugins
In reply to: [AMP for WP - Accelerated Mobile Pages] Can’t Use itemtype markup on ul tagsHi @ahmedkaludi
Thanks for your reply.
I have submitted the issue to you on https://ampforwp.com/support/