johny-dotpad

Forum Replies Created

Viewing 7 replies - 1 through 7 (of 7 total)
  • Forum: Plugins
    In reply to: [Site Reviews] Star rating helper function css broken
    Thread Starter johny-dotpad

    (@johny-dotpad)

    6 years, 11 months ago

    LOL! Think we must have posted replies at the same time! No probs that fixes it for now. Thanks.

    Forum: Plugins
    In reply to: [Site Reviews] Star rating helper function css broken
    Thread Starter johny-dotpad

    (@johny-dotpad)

    6 years, 11 months ago

    Delving deeper the problem is that I have the star helper function in an AJAX request handler.

    The StarRating partial in the plugin checks if is_admin() is false to apply the .glsr- prefix. As an AJAX handler always returns TRUE for is_admin() it won’t add the prefix.

    If I alter the conditional after the return statement in the StarRating class to !is_admin() || wp_doing_ajax() it then will add the .glsr- prefixes.

    Forum: Plugins
    In reply to: [Site Reviews] Star rating helper function css broken
    Thread Starter johny-dotpad

    (@johny-dotpad)

    6 years, 11 months ago

    Hi,

    Thanks for the reply. Wrapping the function output didn’t fix the issue for me unfortunately. I had to do a bit more work to get these to show.

    In the end, I needed to override all the classes concerned by removing the glsr- / gl- prefixes, a bit of a fudge but it seems to be working.

    Until a fix is available, for anyone else in this position here is the css I used, you will need to add relative paths to the star svgs. I copied them to my themes images folder for convenience.

    .star {
	width: 20px;
	height: 20px;
	font-size: inherit;
	background-size: 20px;
        display: inline-block;
}

.star-rating>div,
.star-empty {
	background-image: url([path to]/star-empty.svg)!important
}

.has-error .star-rating>div {
	background-image: url([path to]/star-error.svg)!important
}

.star-half {
	background-image: url([path to]/star-half.svg)!important
}

.star-rating.s10>div:first-child,
.star-rating.s20>div:nth-child(-1n+2),
.star-rating.s30>div:nth-child(-1n+3),
.star-rating.s40>div:nth-child(-1n+4),
.star-rating.s50>div:nth-child(-1n+5),
.star-rating.s60>div:nth-child(-1n+6),
.star-rating.s70>div:nth-child(-1n+7),
.star-rating.s80>div:nth-child(-1n+8),
.star-rating.s90>div:nth-child(-1n+9),
.star-rating.s100>div,
.star-rating>.star-full {
	background-image: url([path to]/star-full.svg)!important
}
    • This reply was modified 6 years, 11 months ago by johny-dotpad.
    Forum: Plugins
    In reply to: [FakerPress] Post generation fails
    Thread Starter johny-dotpad

    (@johny-dotpad)

    8 years, 3 months ago

    Hi Gustavo,

    Just to confirm the update 0.4.11 has fixed the issue now.

    Many thanks
    Johny

    Forum: Plugins
    In reply to: [FakerPress] Post generation fails
    Thread Starter johny-dotpad

    (@johny-dotpad)

    8 years, 4 months ago

    Found a fix for this issue, the error points line 82 of /providers/wp-post.php

    That line calls the FakerPress namespace rather than FakerPress\Utils class

    I changed:

    $content = implode( "\r\n\r\n", $this->generator->paragraphs( FakerPress::instance()->get_qty_from_range( $args['qty'] ) ) );

    to

    $content = implode( "\r\n\r\n", $this->generator->paragraphs( FakerPress\Utils::instance()->get_qty_from_range( $args['qty'] ) ) );

    Forum: Plugins
    In reply to: [Contact Form 7 Polylang Module] bug constant POLYLANG_URL not defined
    johny-dotpad

    (@johny-dotpad)

    9 years, 4 months ago

    Using Polylang 2.1 (not pro) I had same issue, just to confirm that the new release fixes the POLYLANG_URL error.

    However in the top right translations panel when editing the translation I am getting the error:
    Notice: Trying to get property of non-object in .../wp-content/plugins/polylang/admin/admin-links.php on line 22 ]

    This appears twice in the panel. After saving it only saves as another EN version and not in the language it should be – TR in my case.

    • This reply was modified 9 years, 4 months ago by johny-dotpad.
    Forum: Everything else WordPress
    In reply to: Strange – Something may be wrong with ww.wp.xz.cn
    Thread Starter johny-dotpad

    (@johny-dotpad)

    11 years, 1 month ago

    Yep working here now. Good stuff.

Viewing 7 replies - 1 through 7 (of 7 total)