jyd44
Forum Replies Created
-
Forum: Requests and Feedback
In reply to: stylesheet_directory filter called too earlyThanks, I wanted to report an issue.
I will do it in the core.trac
Forum: Plugins
In reply to: [Private groups] Problems with some translationsThanks a lot.
Nevertheless, these chains are also included into your own .pot file. IMHO, it should be better to change the text_domain handle.Forum: Plugins
In reply to: [Pinpoint Booking System - Version 2] Export Booking System bugalready pointed out 3 years ago in this topic:
https://ww.wp.xz.cn/support/topic/export-reservations-to-csv/
Was supposed to be fixed in version 2.4.3 !!!!If you make the bug correction by yourself, don’t forget also to perform the one related to the comma character
Forum: Plugins
In reply to: [Pinpoint Booking System - Version 2] Allow tag in subjectyou just need to call json_decode($reservation->form)
In return, you get an array of objects, each of them being a stdclass in which the “value” attribute is the value in the form, the “id” attribute is the id of the field unuseful info, as you don’t knwo this id, except if you inspect the form-fiels table in the database), and the “translation” attribute is the label which is displayed in the form.Nevertheless, it’s never a good idea to modify a code that you don’t manage yourself. It should be better to ask PinPoint to offer the opportunity to perform some personalization, by using the wordpress filter mechanism, with the appropriate parameters.
Forum: Plugins
In reply to: [Pinpoint Booking System - Version 2] Load on demand/clickOK, just to be a little bit more precise: my goal was to use the PinPoint Plugin as it is, without any modification. This point is very important if you plan to follow the releases of this plugin.
With that in mind, the only way was to find an external solution. I agree that it is only a workaround, and after few search in the PinPoint Code, I’m pretty sure that with some modifications in it, you could do what you plan with an ajax request. (the code executing the shortcode is located in the file includes/calendars/class-frontend-calendar.php and you can see that executing the shortcode set the document ready event to load the content of the calendar. This event will not be triggered by an ajax call. You will have to do it in your own code. One another point is that the treatment of the shortcode add the link to a css file and I have never tried to add such kind of content by an ajax call to a document. Last point is that you need to retrieve in your own code the content of the options for the DOPBSPCalendar init method (see the assets/jquery.dop.frontend.BSPCalendar.js file) ).
The question is : how deep is it necessary to enter into the PinPoint code, is it acceptable ? What about the support if you make some modifications of your own ?So back to your questions:
– is it good practice to use an iframe: We are in the case of same source, which is in my point of view acceptable. Another way is to set a div (for instance) and to load the content of this div with the result of an ajax request.
– loading the calendar on demand: setting the url of the iframe on user’s request with some javascript that you attach to the trigger (any text link, icon or whatever you want) will load the calendar on demand only, which answer to your request.
– I was not talking about developing a new theme, but only to be aware of how to build theme. And yes, developing a dedicated template for a page help to remove all unnecessary assets, like the header of the page, the footer, sidebars and so on, things that you don’t need to display into the frame. But you need to ensure that all necessary wordpress events are triggered (like enqueue_scripts and so on)Hope this clarify my proposal.
Forum: Plugins
In reply to: [Pinpoint Booking System - Version 2] Load on demand/clickMy contribution to your request:
If you plan to publish the calendar in a WP page and if you have sufficient knowledge upon developping a plugin and a theme in WordPress, you could use the following trick:
– create a page with a dedicated template in which you will display the calendar and only the calendar, using the relevant shortcode,
– create the dedicated template. This template must use the strict minimum of the wordpress core to be sure that all necessary resources will be outputted (mainly the js and css theme and from Pinpoint, in order to display the strict minimum (no header, no sidebar, no footer,etc…)
– create your own plugin to manage your own shortcode that you will insert in the page in which you want to display the calendar. In this page, you will also set an iframe, support of the calendar. The shortcode will display something like: “Click here to see the calendar” and an associated javascript will open the frame and set the src of the iframe to the previously created page.
Hope this help to setup your requirementForum: Plugins
In reply to: [Spiffy Calendar] localization in back-endThanks a lot for this improvement.
And, as a bonus, the starting day of the week is also localized !Forum: Plugins
In reply to: [WP Maintenance] Bug preview quand plugin activéMême problème, aucun cache.
version WP: 4.9.8–fr_FR
version plugin: 5.0.1
Bon courageForum: Plugins
In reply to: [Pinpoint Booking System - Version 2] Settings up reoccuring bookingsI don’t know what is the right way to do that. (I may provide a link to a place from which the plugin may be downloaded, but I don’t know if this is allowed on this forum. And I don’t want to publish it in the wordpress plugin repository, mainly because of the extra stuff to perform to do it).
In the mid-time, I have to perform some cleaning into the source code, because, since my last post, I made an integration with another plugin of my own, for mail sending and error management.
Comments in my code are mainly in french, I will certainly have to translate them in english.
Unfortunately, I will leave in few days for a three weeks vacation, and I will not be able to work on this before my return (mid june).If you are still interested, the available features are:
– hours enabled,
– recurring reservation on a single resource, (not tested on a pro version, but provisions made for multi resources), with following criterias: every day, every n weeks,
every (first or second, …) day in the week, and a only three fields in the contact form (this can be easily extended). One mail sent with the list of all the reservations,
– possibility to delete all or some of the resulting reservations from the admin or from a link provided in the mail.
– backup of the tables,
– agenda printed in pdf format for one week,
– on the front-end, free and booked hours are displayed in the upper bar of the day.Hope that will fulfill your requirements. Just remember that few modifications need to be done in the PinPoint Booking code.
My only conditions is that you will have to mention my work and possibly to give me in return the improvements you add to this plugin.
jean-yves
For the last point, you may use plugin like ‘restrict content’ to restrict access to the post or page embedding the calendar to registerd users only.
Forum: Plugins
In reply to: [Pinpoint Booking System - Version 2] Settings up reoccuring bookingsI have written my own companion plugin to fulfill recurring reservations (and few more features, like printing a week agenda, doing backup, etc…), fully based on existing ajax requests of the original plugin. For this, I was obliged to make some bug corrections in the original plugin. These bugs have been reported to the development team since their version 2.4.2 (a long time ago) with a complete description of the bugs themselves and the related corrections (file, line number, etc…) They are now at version 2.7.4 and these bugs are still present.
Having experiment that every new version comes with a lot of new bugs and without any serious non-regression testing, I stick on version 2.4.2, which fully fulfill my own requirements ( reservation of a meeting room, with hours enabled, no payment, no Woocommerce integration, …).
I may provide this companion plugin as is, if someone is interested.Forum: Plugins
In reply to: [Pinpoint Booking System - Version 2] Export Reservations to CSVDespite what you promissed four monthes ago, this bug is still present in version 2.4.9.
Do you have any bug tracking system ?Hello,
It’s what I did following your answer and up to now, I did’nt receive any answer.
Is there a chance get some answer on this topic ?Thanks for the answer.
However, whant about the next upgrade ?
Do I have to repeat this edit at every upgrade ?
Perhaps you could add in a future version the possibility to enter the key into some text field, for instance in the settings area.Forum: Plugins
In reply to: [Pinpoint Booking System - Version 2] Export Reservations to CSVAnd to continue on this thread, you should also escape the comma, as we may find this character in the messages, for instance.