linus89

Ah, too bad. I think it would make sense for almost everyone to make it use the wordpress titles and names of e.g categories, custom post types etc instead of the seo titles since it just gets very confusing as breadcrumbs and will not fit in the google serps as it is right now

Hopefully it makes it into the next update

Great thank you!

Good morning,

I noticed that it will require a is_archive check for when it’s inputting the css aswell, since the archive pages for custom post types will output the css for the custom post types pages instead of archive css, which isn’t really a edge case i feel like

I’m guessing it’s here but not sure

} elseif ( ( $this->criticalcss->is_api_active() || $this->criticalcss->is_rule_manual( $rule ) ) && (strpos( $type, 'custom_post_' ) === 0 && ! $is_front_page && !is_archive()) ) {

Tested it out and it works as intended now

Sorry for all the spam

• This reply was modified 3 years ago by linus89.

Yes exactly, or is_archive works aswell, i’m not 100% sure it’s working yet, waiting for pending job on criticalcss

It will run since its || !is_page() which returns true

I ended up reordering the posts in author so that the custom post types comes last, should work good as long as it doesn’t fetch from the last pages.

Thanks for all the help! If you make an update to the plugin maybe you can add a is_archive or is_author check for the custom post type check for the jobqueue

Best regards

I’m guessing it is because of the order this comes:

            } elseif ( strpos( $type, 'custom_post_' ) !== false && ( ! $forcepath || ! is_page() ) ) {
                // Match custom post types and not page or page not forced to path-based.
                if ( get_post_type( get_the_ID() ) === substr( $type, 12 ) ) {
                    $page_type = $type;
                    break;
                }
            }

wouldn’t a is_archive() check solve it there?