mediumdeviation
Forum Replies Created
-
Forum: Plugins
In reply to: [Facebook Comments] Comment width set to 0px on FirefoxHmm, that didn’t work (I don’t think CSS written on the parent page can affect anything inside the iframe anyway?).
Tried a few other things (adding the following to the CSS, changing the width back to 100%), and suddenly the comments are showing up again.
.fb-comments span, .fb-comments iframe { width: 100% !important; }I’ll mark this as resolved for now, though this seems to be an intermittent issue.
RE: HTML, I think it would be best to have the id/class attributes, I think it would be best to have a toggle somewhere for it, and have it turned off (ie. use
class) for new installation, while keeping it on (ie. useid, so it doesn’t break anything) for upgrading users.This way you get to keep backwards compatibility while making sure that the plugin’s HTML stays valid moving forward.
This is the code I’m adding to the custom JavaScript under display options to help with the loading problem. I think it’s entirely find to include this in the plugin itself.
$('.sbi_item.sbi_new img').each(function(){ $(this).fadeTo(0, 0).on('load', function(){ $(this).fadeTo(200, 1); }); });