mensch

Yes, looking at the code there seem to be a lot of hooks in the constructor which will be duplicated this way.

As the plugin adds a global variable of the Simba_Two_Factor_Authentication_Plugin class instance (which extends Simba_Two_Factor_Authentication_1), the enqueue method can be used directly, which should avoid the potential duplication issues:

add_filter('do_shortcode_tag', function($output, $tag) {
    if ('pmpro_login' == $tag && class_exists('Simba_Two_Factor_Authentication_1')) {
        global $simba_two_factor_authentication;
        $simba_two_factor_authentication->login_enqueue_scripts();
    }
    return $output;
}, 10, 2);

I don’t think requesting official support will be necessary in my case, as supporting the shortcode is enough for me and that can be done by amending the do_shortcode_tag on line 137 of simba-tfa/login-form-integrations.php as mentioned in my initial post.

As those changes will be overwritten with every update of the plugin, I’ve updated the functions.php file of my theme instead with the following filter which ensures the enqueuing of the relevant assets on the login page:

/**
 * Add support for the Two Factor Authentication plugin
 */
add_filter('do_shortcode_tag', function($output, $tag) {
    $tfa = new \Simba_Two_Factor_Authentication_1();
    if ('pmpro_login' == $tag) $tfa->login_enqueue_scripts();
    return $output;
}, 10, 2);

• This reply was modified 1 year, 5 months ago by mensch.
• This reply was modified 1 year, 5 months ago by mensch.
• This reply was modified 1 year, 5 months ago by mensch.

Ah, thank you for the context. I inherited The Events Calendar from the previous maintainer of the website and I’m not that happy about it for obvious reasons…

I think I’ll wait for 4.2, as the mentioned issue seems to have a patch. Otherwise I’ll have to migrate to another plugin. Events Maker seems to be a better WordPress citizen with regards to interoperability with multilingual plugins, I believe?