Michael
Forum Replies Created
-
Hi Muhammad,
The rollback was to version 3.0.0.
Luckily, a rollback is just a composer install and a release pipeline for us, but it’s not instant of course, so in the meantime customers are calling or emailing reporting issues.
While I appreciate you taking the time to reply, with all the UI changes and added features I won’t be using, I will write my own honeypot implementation instead.
Hi Muhammad,
To give you a bit more context. We use the honeypot plugin in a custom-styled WP “framework” in a centralised setup. We do not provide our users admin access; we try to minimise what they see and have to deal with, allowing them to focus on what matters, managing their content. So your latest update ended up giving 400+ sites a plain-text honeypot tag because an opt-in flow was presented in the admin screens (breaking the original purpose of this plugin). We do not expect our customers to have to deal with this. So something you might see as a simple single click ends up being an impactful change for us. I ended up reverting to a previous version and will completely remove this plugin asap.
Imo, you should have moved to a new plugin and abandoned this one instead.
Forum: Plugins
In reply to: [W3 Total Cache] Undefined array key “timeout”PR has been created here: https://github.com/W3EDGE/w3-total-cache/pull/542
Forum: Plugins
In reply to: [W3 Total Cache] Undefined array key “timeout”@vmarko Thanks!
Quick question for any future issues if they may arise, would it be better to create a ticket on GitHub or report it here? I could try to provide a PR on GitHub to resolve the issue.
Forum: Plugins
In reply to: [W3 Total Cache] Undefined array key “timeout”Hi @vmarko,
Sorry, I thought you suggested a fix instead of requesting me to check if this would resolve the problem.
Looking at the code I already knew this would fix it. But I double-checked and can confirm this resolves the issues. Adding the configuration values will remove the warnings.The better fix would be to retrieve these values from the stored config instead of hardcoding values to 0.
Forum: Plugins
In reply to: [W3 Total Cache] Undefined array key “timeout”@vmarko thanks for your reply but this is not my code, this is the W3TC plugin code. This is a bug in the plugin not in my codebase. That’s why I’m posting here.
https://plugins.trac.ww.wp.xz.cn/browser/w3-total-cache/trunk/ConfigCache.php#L73
This config (
$engineConfig) is passed to the following constructor:
https://plugins.trac.ww.wp.xz.cn/browser/w3-total-cache/trunk/Cache_Redis.php#L91Forum: Plugins
In reply to: [W3 Total Cache] Undefined array key “timeout”Thanks, @vmarko.
If you need more input or a git repo to be able to reproduce the issue please let me know.P.S.
I don’t think the warnings are breaking anything at the moment but it’s not possible to configure certain settings and it is flooding logs and CLI output.Forum: Plugins
In reply to: [W3 Total Cache] Undefined array key “timeout”Hi @vmarko,
No changes are made to the db-config.php, this file is in my git ignore and I always let w3 be responsible for creating it.
I’m currently running PHP 8.1, but we also have loads of production sites running 8 with the same issue. And I’ve just tested 7.4 same issues.
To be clear it’s not just using PHP Redis, it’s storing the W3TC config in Redis using the constants. Following the stack trace and looking at the code I shared this will always throw these warnings since the array keys are never filled in ConfigCache.php on line 74.
Kind regards,
Michael