mofo.is.guilty

Hi Johan,

I was browsing this board just to suggest you a very similar upgrade.

Your plugin actually allows template overriding, but only when the content block is added as a widget and not as a shortcode.

I’d suggest you to wrap the template handler you are using in function widget() to something like function cpw_template_handler() so you can call that in function custom_post_widget_shortcode() as well.

bb
mofo

• This reply was modified 8 years, 2 months ago by mofo.is.guilty.

Seems like it’s breaking on WP 4.3 and following.

ACF plugin has something like this in wysiwyg.php

// WP 4.3
if( version_compare($wp_version, '4.3', '>=' ) ) {

	add_filter( 'acf_the_editor_content', 'format_for_editor', 10, 2 );

	$button = 'data-wp-editor-id="' . $id . '"';

// WP < 4.3
} else {

	$function = ($default_editor === 'html') ? 'wp_htmledit_pre' : 'wp_richedit_pre';

	add_filter('acf_the_editor_content', $function, 10, 1);

	$button = 'onclick="switchEditors.switchto(this);"';

}

So here’s a quick and partial fix.

In acf-qtranslate/src/acf_5/fields/wysiwyg.php (line 142)

replace

<?php if( user_can_richedit() && $show_tabs ): ?>
	<div class="wp-editor-tabs">
		<button id="<?php echo $id; ?>-tmce" class="wp-switch-editor switch-tmce" onclick="switchEditors.switchto(this);" type="button"><?php echo __('Visual', 'acf'); ?></button>
		<button id="<?php echo $id; ?>-html" class="wp-switch-editor switch-html" onclick="switchEditors.switchto(this);" type="button"><?php echo _x( 'Text', 'Name for the Text editor tab (formerly HTML)', 'acf' ); ?></button>
	</div>
<?php endif; ?>

with

<?php if( user_can_richedit() && $show_tabs ): ?>
	<div class="wp-editor-tabs">
		<button id="<?php echo $id; ?>-tmce" class="wp-switch-editor switch-tmce" data-wp-editor-id="<?php echo $id; ?>" type="button"><?php echo __('Visual', 'acf'); ?></button>
		<button id="<?php echo $id; ?>-html" class="wp-switch-editor switch-html" data-wp-editor-id="<?php echo $id; ?>" type="button"><?php echo _x( 'Text', 'Name for the Text editor tab (formerly HTML)', 'acf' ); ?></button>
	</div>
<?php endif; ?>

This will restore base functionality.

Then comment line 44 in acf-qtranslate/assets/common.js

// switchEditors.switchto(this);

Which is a loop to switch all editor panels to the same mode in every language.