mpserellis

Hello,

Right, the video you provided does NOT replicate the issue I described which is why I kept replying to your comments. A number of times now I told you that it ONLY occurs when you ONLY use the price slider! The video you provided shows you selecting one of the check boxes!

I have just checked your demo site again and it is NOT working there, it still gives “Oops! That page can’t be found.”.

Please try it again on your site and use ONLY the price slider to filter. Go to page 3 of your demo site and then slide the max price down to 16. Do not select any other filter option. You WILL get page not found just as I do.

Please, I am asking you to re-read my comments describing how to replicate the issue.

Thank you
Mark

Hello,

This is how I have fixed the problem. I changed part of the function woof_get_submit_link() found in front.js by adding one line as shown below. The line I added removes the /page/x from the url before submitting:

    if (Object.keys(woof_current_values).length === 2) {
	if (('min_price' in woof_current_values) && ('max_price' in woof_current_values)) {
	    var l = woof_current_page_link + '?min_price=' + woof_current_values.min_price + '&max_price=' + woof_current_values.max_price;

      l = l.replace(new RegExp(/page\/(\d+)\//), "");

	    if (woof_is_ajax) {
		history.pushState({}, "", l);
	    }
	    return l;
	}
    }

This is something you do further down the same function if there are other options selected but in this case we only have min_price and max_price so before my fix your javascript was not returning to page 1.

If this helps anyone before the plugin author releases a fix and if you have enabled “Optimize loading of WOOF JavaScript files” found under Settings > Advanced then you will also need to change the front_comprssd.js script or disable the optimization so that it uses front.js.

Regards
Mark

• This reply was modified 6 years, 8 months ago by mpserellis.

Hello,

You don’t need that because the issue is present on your demo site as demonstrated previously. Have you checked? Have I not explained well enough that you can replicate it? I do not wish to put my link here.

Thank you
Mark

Hello,

Thank you for taking the time to do the screen capture video. After a lot of searching the problem still persists. I found that the problem is also present on your demo site:

demo.products-filter.com

Please go to page 3 on your demo site. Then using only the price slider change the maximum to $15 and click filter. I get page not found.

What I found was that if you use any other filter it works correctly, the bug is only present when filtering on price only.

Thank you
Mark

Right, I have implemented a workaround therefore the failing page url given above will no longer report an error.

“All In One SEO Pack” plugin provides a filter when creating the analytics code snippet and so I was able to change the code so that it only executed after the page had loaded and made it use whatever was set as the GoogleAnalyticsObject (i.e. window[GoogleAnalyticsObject]), on pages with SweetCaptcha that was the sweetcaptchalyticsObj, on other pages that was ga.

I don’t pretend to know how the analytics script works but this workaround made the Tag Assistant extension happy so I think Google should be happy. I also don’t really know who should change their code so I will mark this topic as resolved.