nikhil710

Hi @mbis,
Thanks for the response, I understand your stance on modifying the specific function within the plugin. I was just curious to know if i could proceed with the temporary code changes i made in that ‘custom_scripts_enqueue‘ function in order to deal with url_to_postid($url) function if it doesn’t return post ID of CPTs pages and thinking of undoing it after the update but i dont see this happening now. So, I’m gonna find proper workaround in the function. Thanks for your understanding and support.

HI @mbis,

Thank you for your continued support and analysis of the issue.

Upon reviewing the provided code snippets, it appears that the discrepancy lies in the recent changes made to the Permalink Manager core functions, specifically in “includes\core\permalink-manager-core-functions.php,” line number 520.

The new 2.4.1.5 version’s code snippet:

if ( $return_object && ! empty( $element_object ) ) {
    return $element_object;
} else {
    return $query;
}

Differs from the previous version’s code:

if ( $return_object && ! empty( $term ) ) {
    return $term;
} else if ( $return_object && ! empty( $post_to_load ) ) {
    return $post_to_load;
} else {
    return $query;
}

i think the change in logic might be causing the issue with the url_to_postid function.

Considering the old version’s code worked flawlessly, would it be possible to revert back to the previous logic or explore an alternative solution that ensures the proper functioning of the url_to_postid function?

I appreciate your attention to this matter and your dedication to resolving this issue promptly. Please let me know if there’s any additional information or testing I can assist with.

Hi @mbis,

I’m using this funtion in init hook, here is the code snippet:-

function custom_scripts_enqueue(){    
    $actual_url = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on' ? "https" : "http") . "://$_SERVER[HTTP_HOST]".strtok($_SERVER["REQUEST_URI"], '?');
    $post_id = url_to_postid($actual_url);
    var_dump($post_id,' ',$actual_url);die;
}
add_action('init','custom_scripts_enqueue',1);

and here is the values i get from the var_dump present in the snippet provided above

int(0) string(1) " " string(64) "https://www.carinsurance.com/state/California-car-insurance.aspx"

So i think, in wp_head hook the url_to_postid() function is working fine but in init hook its not working for CPTs(custom post types pages).

let me know if there anything needed to be done from my end

HI @mbis,

Thanks for responding, so, after downgrading permalink manager to version 2.4.1.3, the issue is gone, however after updating the very same plugin to version 2.4.1.5 again, it reproduces the issue.

Thanks,
Nikhil Mistry