Mykyta Synelnikov
Forum Replies Created
-
Hi @unif
Thanks for your report and links to WP-CLI repo.
Could you try to add this constant defining to wp-config.php file?define('FS_METHOD', 'direct');As soon as Ultimate Member plugin uses the WordPress native $wp_filesystem methods to initialize own filesystem variables we have to initialize $wp_filesystem if it’s not exists.
See the code reference here.
Please let me know if that works or if you have other questions,
Best Regards!Hi @34503895-1
And thanks for your debugging steps.
Probalby user_id = 0 is related to the guest user. We will add the fix to Ultimate Member in 2.10.7 version.
You could returnadd_filterand change the handler this way:
https://github.com/ultimatemember/ultimatemember/pull/1756/files#diff-a18511a1c411187885ff743ed8c1af2aa950417d8015ec8a1678dda2d2046e7bR97-R99It should also help you on your website,
Best Regards!Hi @34503895-1
Wow, it looks interesting. Can I ask your help with a small debugging steps? It’s also important for the future version fix.
If you can return the add_filter that you have removed for the fix and addvar_dump( $comment );
Before this line: https://github.com/ultimatemember/ultimatemember/blob/b8216dee2ad2e14c665210f23cd4e99fc12626e4/includes/frontend/class-user-profile.php#L98
And send me the result of dump, it can help to avoid the conflicts in the future 2.10.7 version.
I guess that$comment->user_idis empty and URL function returns the User Profile URL of the current logged in user.
Thanks in advance,
Best Regards!Hi @34503895-1
Could you also try to remove this line and test how the comment author links look like:https://github.com/ultimatemember/ultimatemember/blob/b8216dee2ad2e14c665210f23cd4e99fc12626e4/includes/frontend/class-user-profile.php#L25
Please let me know,
Best Regards!Hi @34503895-1
Please check the changes in this PR.
https://github.com/ultimatemember/ultimatemember/pull/1756/filespublic function change_comment_author_url( $comment_author_url, $comment_id, $comment ) {
if ( ! is_null( $comment ) ) {
return um_user_profile_url( $comment->user_id );
}
return $comment_author_url;
}It could help to fix your issue.
Let me know if that works,
Best RegardsHi @biotrace
After my test registration that I have done (via this page Account Application – BioTrace ) I got the email notification with this content:
https://jam.dev/c/8d67d1f3-b6b6-4f76-94c8-363e60090aa4
There isn’t a replacement for the {password_reset_link} placeholder. It looks, it was executed using an old code base in a custom code.If possible, could you please search your project-especially any directories that may contain customizations for the line ‘approved_email’?
Starting with version 2.10.5, placeholders are now generated and passed directly (PR: #1694).
I have resolved the similar issue but for another placeholder {submitted_registration} today: https://github.com/ultimatemember/ultimatemember/issues/1718
Let me know,
Best Regards!Hi @biotrace
For some reason, I’m unable to see the registration form on the predefined page selected in the Ultimate Member settings:
https://jam.dev/c/2036e18d-1d06-4f66-bf65-3292546da6ca
The same applies to the Users page. I found a working registration form here. Account Application – BioTrace and tested it; it appears to work without requiring admin review.
Unfortunately, just the list of predefined pages isn’t enough to fully investigate the issue. Could you please share your Site Health information? More information about Site health you can find here.
Please provide any additional details that might help us move forward.
Best Regards!Hi @jdaydesign
Thank you for your report, and I’m sorry to hear that you’re still experiencing issues even with the recent 2.10.5 version.Unfortunately, we don’t have enough input data to investigate the issue properly. On a fresh installation without any customizations, plugins, or themes that might cause conflicts, everything seems to work as expected. User got the proper email notification with the proper userdata and reset password URL.
Could you please share your Site Health information and any additional screenshots or screencasts that might help us? You can find more info about Site Health here.
Best Regards!Hi @biotrace
I hope I’m not bothering you, but could you please check how the recent 2.10.5 version works without the extra code snippet from @missveronicatv. We’re just looking to confirm that the core email notifications work as expected out of the box..
P.S. @missveronicatv thank you for your help and for suggesting the hotfix before the 2.10.5 release.
Best Regards!Sorry to hear that, could you check that the user you made the active or reject its registration has not empty the first and last name? I have tried with the recent 2.10.5 version on my clear localhost installation and it works:
screenshot-01.pngBest Regards!
Hi @nickbats
Sorry for the delayed reply, please try to run the scheduled action manually here:
https://jam.dev/c/37cb3a55-5b5b-4fbc-b71a-e661677fa8e9Also guys, if you have some 3rd-party registrations on your website sometimes admin notice can be visible until these undefined users are approved via scheduled action.
Let me know if you still have the issue or questions,
Best Regards!- This reply was modified 11 months, 2 weeks ago by Mykyta Synelnikov. Reason: embed a proper link to screenshot
Hi @huntersbest
Thanks for prompt clarifying and letting us know.
For some reason yes. And it also triggers hooks related only for sending wp-admin/user-new.php.
https://github.com/ultimatemember/ultimatemember/blob/a0162b1a4cf0dfec763369d03037bc14718a36b5/includes/core/class-user.php#L965
Here we checkis_admin()also during wp_insert_user function hook’s ‘user_register’ callback.
Could you also ask Ninja Forms team aboutis_admin()condition during the registration form submission? I think their dev team knows better about submission process of their forms.
I also created the PR with the possible fix and avoid using the is_admin() in our callbacks, but looks like for your case it’s not a solution.
https://github.com/ultimatemember/ultimatemember/pull/1711
Anyway if you can check it and how it works on your installation, will be great.
P.S. Is it possible to use Ultimate Member Registration forms for you or there are some issues you have faced during setup?
I’ll be in touch,
Best Regards!Hi @huntersbest
Sorry for the delayed reply and thanks for the reporting and patience.
Probably we need to make more debugging on your side.
Conditional Tags – Theme Handbook | Developer.ww.wp.xz.cn based on the official WordPress docs is_admin() condition works (qualstrue) only for wp-admin screens.
Please, could you clarify what do you mean byfrontendon your installation and what do you mean byendpointin the line below:if this redirects to an endpoint – user will always be admin
Probably do you use some 3rd-party integration e.g. REST API or some requests that can trigger is_admin() condition? If you have some custom endpoint redirects, could you make them later?
Action: um_registration_complete – Ultimate Member Hook Docsum_send_registration_notificationcallback has 10 priority;um_check_user_statuscallback (with Ultimate Member built-in redirects based on User Roles settings) has 100 priority;
In the custom redirects cases it’s possible to use 11 priority and redirect user to endpoint after email sending callback.
It works properly for standard WordPress installations where frontend it’s a Registration page, but is_admin() triggers when User has been added via wp-admin/user-new.php by Administrator.
Please let me know,
Best Regards!Hi @lisakatrin and @rb285
Thanks for letting us know about this issue and sorry that it was triggered on your websites. We have tested with a big array of users on our dev environments and it was good. But for sure, there can be some issues on the live.
At the first, you could ignore this admin notice because it cannot be reset during the schedule action because some users (who hadundefinedaccount status) was approved manually or deleted out of the schedule action flow.
If you still use 2.10.3 version and want to remove this notice. Please replace files on your website using the recent PR files.
* Filewp-content/plugins/ultimate-member/includes/common/class-users.phpto this
raw.githubusercontent.com/ultimatemember/ultimatemember/5de4986d2eff41dad686a0dbfbb21b274005383b/includes/common/class-users.php
* Filewp-content/plugins/ultimate-member/includes/common/actions/class-users.phpto this
raw.githubusercontent.com/ultimatemember/ultimatemember/5de4986d2eff41dad686a0dbfbb21b274005383b/includes/common/actions/class-users.php
As soon as you run the actionum_schedule_account_status_checkmanually or it will be run scheduled, the notice has to be hidden.
There is the fix that handles the cases when users was approved manually or deleted out of the schedule action flow.Also, if you turn on WP_DEBUG_LOG it’s possible to see the log of the UM schedule actions. We are planning to log our actions in other specific way to avoid using native WP_DEBUG_LOG.
Please let me know if you have other questions,
Best Regards!Hi @grof ,
Please see this part of the code. ultimatemember/includes/common/class-users.php at 8d33c43130c6f49694f90c00a23ee5661d43889f · ultimatemember/ultimatemember
Inactive users can be only reactivated so please use this function for inactive users:UM()->common()->users()->reactivate($user_id);
Please let me know if that works,
Best Regards