Forum Replies Created

Viewing 15 replies - 106 through 120 (of 373 total)
  • Thread Starter one3rdnerd

    (@one3rdnerd)

    Hi @molongui

    Anyway, yes, in your case you’ll be fine. Forget about this drawback

    Ah yes, that’s fine in my case.

    It is actually our plugin the one placing that space there. It doesn’t expect the last delimiter to start with a symbol. We could add some logic to prevent that space being added if the string provided as delimiter starts with a “,” or “.”

    I think it would be smart to have it remove the space if . or , was used, or just a checkbox option above the field which says “Remove extra space”

    We should look into how BB has that author boxed coded to provide an accurate answer. Anyway, it must have to be something with the fact that now your post has two authors (John and Natalie). Remember that regardless you using the co-authors feature this way, you are actually configuring the post to have two authors.

    However, I guess we could add a hook you can use to avoid your author box being modified.

    Okay, yes I think that would be good. If you send me your email address I can send you a copy to investigate if you want.

    I’d say it has nothing to do with where the image is retrieved from. I mean, if you upload a local image for your first author, it should be displayed. However, no matter what, avatar for the second author/reviewer won’t be displayed. The Pro version of our plugin provides you a shortcode to retrieve the avatars for all the authors in a post, so you can make it display in front of the byline. Here you have the doc.

    Okay, I don’t know if the client requires the avatar, but I will note that for if I do need it.

    Yes, a <br> breaks the links in the byline for a multi-authored post. Sorry.

    Could you create an option to make it, so each author is on its own line with a checkbox in a future update?

    Thread Starter one3rdnerd

    (@one3rdnerd)

    I also tried to add a line break with <br> and it works but it breaks the link and makes everything link to the first author.

    Default author bios are broken even after turning these settings off in the plugin to remove the extra fields and the Molongui bio etc.

    Default author bio box ends up having both names added when we only want one.

    Please advise.

    Thread Starter one3rdnerd

    (@one3rdnerd)

    Okay I have given this a try and its sort of working out of the box but there are a couple of issues.

    Please see this video:

    1) Why is there a space before the full stop/period.
    2) Why does it impact the author bio box at the end?
    3) Can we set it to output the author avatar in the byline? I added a local author avatar but it doesn’t show for the second author, only the first one where gravatar is used.

    Please advise.

    Thread Starter one3rdnerd

    (@one3rdnerd)

    Hey @molongui

    Thank you for getting back to me.

    Okay, I might give that a try.

    As for the drawback, I wasn’t 100% sure what you mean by if we don’t have multi-authored posts?

    All posts are written by one writer, never more than one.

    But different posts on this site are written by different authors and fact checked by different fact-checkers.

    I’m assuming that means we will be fine?

    We are using BeaverBuilder which adds the bylines, I was under the impression I would have to build my own shortcode to output the new byline though so it can show two as we can’t edit the module used by Beaverbuilder for this byline I will need to create a new shortcode.

    Please advise if that all seems fine to you?

    Thread Starter one3rdnerd

    (@one3rdnerd)

    @webtoffee

    Yes, I know Google Pay doesn’t work in Safari, but why does Apple Pay only show in Chrome and not Safari? Surely that should be supported?

    Thread Starter one3rdnerd

    (@one3rdnerd)

    Okay, I retried it today on Windows + Chrome, and the Google Pay button is showing now on checkout and cart.

    Strangely though, on iPhone, it shows Google Pay on the Chrome browser but not on Safari on iPhone.

    I tried switching to the default WordPress theme, and I get the same result.

    So to recap

    Windows + Chrome = Works in all locations, product page, cart and shop

    iPhone + Chrome = Works in all locations, product page, cart and shop

    iPhone + Safari = Doesn’t show anywhere.

    I have tested on my own iPhone and using LambdaTest with iPhone + Safari.

    Any ideas why it would work everywhere but iOS Safari?

    Thread Starter one3rdnerd

    (@one3rdnerd)

    I tried all of this and it didn’t work but I found the solution when looking at the console I could see mixed content issues with http URLs being loaded.

    We changed the URL to https under Settings > General and that resolved it.

    Thanks for your help.

    Ditto

    Thread Starter one3rdnerd

    (@one3rdnerd)

    Thank you Paul.

    That one works now and works for my other taxonomy.

    Only improvement I can see.

    It removes the final comma which is great and I managed to edit it so it includes a full stop/period after the final term but is there a way I can get “and ” to show before the final term.

    I tried with the below and the period works but the and ends up at the very start of the entire output.

    
    return sprintf(
    	'<p>and %s.</p>',
    	implode( ', ', $term_links )
    

    I’m sure this shortcode plugin will be very useful for people, myself included on other sites.

    Thanks again.

    • This reply was modified 3 years, 9 months ago by one3rdnerd.
    Thread Starter one3rdnerd

    (@one3rdnerd)

    Ah, okay, yes, it’s just a standard connection between custom post type and taxonomy rather than using relationships.

    Thank you. I will await your update.

    Thread Starter one3rdnerd

    (@one3rdnerd)

    Hi Paul,

    Firstly, thank you very much for your help.

    I just gave that a try and updated it to your updated copy.

    Unfortunately, nothing is outputting for me, but maybe that’s due to the taxonomy and field meta key being the same.

    I checked the settings, and I have Override WP Metadata values disabled.

    I changed the field key to be unique, so it’s now $field_meta_key = ‘talent-category-key’; but still nothing shows.

    I’m definitely using this on a page where terms are assigned because this is actually part of a migration from using Types Toolset (which is why I had to keep the taxonomy ID/slug as it was previously).

    Here’s a video to show you what I’m working with.

    Also, I will need to create some more copies of this plugin once working, as this is one of a few different taxonomies I need to do the same with. It would be even better if I could modify it so I could put the taxonomy slug in the shortcode rather than having it hard coded because then I could use the same plugin and shortcode for different taxonomies.

    Feel free to watch it on 1.5x speed 🙂

    Thread Starter one3rdnerd

    (@one3rdnerd)

    Thanks Paul.

    I will give this a test in a moment and let you know how I get on. I will have to change the taxonomy’s underscore to a hyphen so I will do that first.

    I appreciate you.

    Thread Starter one3rdnerd

    (@one3rdnerd)

    Hi Jory,

    These are the two I am using (your example is the same as my second one I shared in my last comment) The only difference is you removed talent-type and changed it to category.

    [pods]{@talent-type}[/pods].

    [pods][each talent-type]{@name}, [/each][/pods]

    Please note, this relies on you having the taxonomy “talent-type” so maybe that’s why it didn’t work for you.

    My issue is, the first example is formatted perfectly, but I can’t get the terms to be clickable.

    The second one creates link, but the formatting is dreadful without commas, so I can’t find a way to use it. Adding comma’s outside of the magic tag means I end up with a comma at the very end, wheras that should be a period like in the first example.

    Please advise.

    Thanks for your time.

    Thread Starter one3rdnerd

    (@one3rdnerd)

    Here’s a screenshot of the two outputs.

    The first shows how I want it but the links aren’t clickable.

    The second shows them as clickable but there’s a comma at the end and no “and” before the final term.

    View post on imgur.com

    Thread Starter one3rdnerd

    (@one3rdnerd)

    @devnihil

    No problem. Switching Yoast SEO off and Rank Math on allowed us to solve this problem.

    Moving all of our sites off Yoast moving forward.

    Will leave this open in case someone can fix it for others.

    Thanks.

Viewing 15 replies - 106 through 120 (of 373 total)