pdg87

Okay I got it.. I had a pre_get_posts in my functions that was getting the main query and adding my custom post type to it when on categories, this was so that the custom post type showed in the categories, as they are not default posts. It was not set up accurately enought and was merging with this query:

SELECT wp_posts.ID
FROM wp_posts
WHERE 1=1
AND wp_posts.post_type = 'is_search_form'
AND ((wp_posts.post_status = 'publish'))
ORDER BY wp_posts.post_date DESC

and as a result it was finding 50k results and running the below for the 50k results.

SELECT option_value
FROM wp_options
WHERE option_name = 'is_search_69594'
LIMIT 1

thanks for your time and for the plugin. Have a great day.

Hi Vinod,

The site is still local, I will see if I can get it on a test server. It’s the get_option function from wordpress option.php that seems to be causing this. If I comment this block ou within it the pages load okay:

if ( false === $value ) {

$row = $wpdb->get_row( $wpdb->prepare( "SELECT option_value FROM $wpdb->options WHERE option_name = %s LIMIT 1", $option ) );

// Has to be get_row() instead of get_var() because of funkiness with 0, false, null values.

if ( is_object( $row ) ) {

$value = $row->option_value;

wp_cache_add( $option, $value, 'options' );

} else { // Option does not exist, so we must cache its non-existence.

$notoptions[ $option ] = true;

wp_cache_set( 'notoptions', $notoptions, 'options' );

/** This filter is documented in wp-includes/option.php */

return apply_filters( "default_option_{$option}", $default_value, $option, $passed_default );

}

}

again this only happens on category pages when the plugin is enabled. I guess it is doing an option lookup for every post for some reason..

• This reply was modified 11 months, 4 weeks ago by pdg87.
• This reply was modified 11 months, 4 weeks ago by pdg87.

Ah that’s a shame seems close, maybe I should switch to using just custom fields?

I’m going to carry on for now with some other areas of the website, but will address this again soon and see if I can use custom fields/make do with more simple query.

I may drop you PM in the coming weeks if this blocks me too much. Would be great if you could help out in return for some beer money 🙂 Thanks again for the help!

FWIW, _store_brands has always been in the db, I noticed it the other day when having a look with the value field_blah (I think this is he unique key for the custom field). What were you trying to do with this value? overwrite it with an array?

Either way hopefully there’s some useful info in here for noobs like myself.

No thats not a correct value for brand_name. Looking in the db, field_55590c17ac022 is a value for _store_brands.

hmm looks like the data is not getting populated correctly..

Array
(
    [0] => field_55590c17ac022
)

SELECT wp_postmeta.meta_value FROM wp_posts
          INNER JOIN wp_postmeta ON ( wp_posts.ID = wp_postmeta.post_id )
          INNER JOIN wp_postmeta AS mt1 ON ( wp_posts.ID = mt1.post_id )
          WHERE wp_posts.post_type IN ( 'designers', 'stores' )
          AND wp_posts.post_status = 'publish'
          AND wp_posts.ID NOT IN ( 18 )
          AND (
          	   wp_postmeta.meta_key = 'alternative_brand_names'
	           AND mt1.meta_key = 'brand_name'
	           AND CAST( mt1.meta_value AS CHAR) IN (    'field_55590c17ac022' )
              )
          GROUP BY wp_posts.ID
          ORDER BY wp_posts.post_date DESC

Array
(
)

Yeah sorry it’s confusing with similar CF and brand names and my php is terrible. I updated the functions.php file and then resaved a store post with store_brands CF. This is the code I have in single-stores.php (I changed the name of post type from brands to ‘designers’ and custom field name brands_name_alt to ‘alternative_brand_names’ as I had names them wrong in previous posts 🙂

<?php 

global $wpdb;

$post_id    = absint( $post->ID );
$post_types = array( 'designers', 'stores' );
$list       = (array) get_post_meta( $post_id, "_store_brands", true );
$array      = array_filter( array_map( 'trim', $list ) );

if ( !empty( $array ) &&  $post_id ) {

	$post_type_sql  = "'" . implode( "', '", array_map( 'esc_sql', $post_types ) ) . "'";
	$meta_value_sql = "'" . implode( "', '", array_map( 'esc_sql', $array ) ) . "'";

	// First query to get the brands_name_alt meta values
	$query = "SELECT $wpdb->postmeta.meta_value FROM $wpdb->posts
          INNER JOIN $wpdb->postmeta ON ( $wpdb->posts.ID = $wpdb->postmeta.post_id )
          INNER JOIN $wpdb->postmeta AS mt1 ON ( $wpdb->posts.ID = mt1.post_id )
          WHERE $wpdb->posts.post_type IN ( $post_type_sql )
          AND $wpdb->posts.post_status = 'publish'
          AND $wpdb->posts.ID NOT IN ( $post_id )
          AND (
          	   $wpdb->postmeta.meta_key = 'alternative_brand_names'
	           AND mt1.meta_key = 'brand_name'
	           AND CAST( mt1.meta_value AS CHAR) IN ( $meta_value_sql )
              )
          GROUP BY wp_posts.ID
          ORDER BY wp_posts.post_date DESC";

	$meta_values = $wpdb->get_col(  $query );

	$args = array(
		'post_type'    => $post_types,
		'meta_query'   => array(

			'relation' => 'OR',

			array(

				'relation' => 'OR',

				array(
					'key'     => 'brand_name',
					'value'   => $array,
					'compare' => 'IN'
				),

				array(
					'key'     => '_store_brands',
					'value'   => $array,
					'compare' => 'IN'
				),
			)
		),
	);

	// Check if meta values were found for the brands_name_alt key
	if ( !empty( $meta_values ) ) {

		// merge all meta values
		$all_values = array();
		foreach ( $meta_values as $value ) {
			$value = array_filter( array_map( 'trim', (array)  explode( ',', $value ) ) );
			$all_values = array_merge( $all_values, $value );
		}

		// Query for all posts with the store_brands values in the brands_name_alt values
		$args['meta_query'][] =  array(
			'key'     => '_store_brands',
			'value'   => $all_values,
			'compare' => 'IN'
		);
	}
	$custom_query = new WP_Query($args);
}

while($custom_query->have_posts()) : $custom_query->the_post(); ?>

	<div <?php post_class(); ?> id="post-<?php the_ID(); ?>">
		<h1><a href="<?php the_permalink(); ?>"><?php the_title(); ?></a></h1>
		<?php the_content(); ?>
	</div>

<?php endwhile; ?>
<?php wp_reset_postdata(); // reset the query ?>

There is a good chance there is something wrong with what I have added. The above just returns both store posts I have made.

If I move the while statement above the last trailing { the page doesn’t load.

great, I will report back. Thanks for taking your time to help Keesie, Much apprecited!