peterjanes

@cardoza and @kitelife and others with missing groups:

(Edited to use the solution in current SVN instead)

Instead of changing $wpdb->prepare to $wpdb->query, just remove the $wpdb->prepare( and the closing ), i.e. change

$rows = $wpdb->get_results( $wpdb->prepare( "SELECT {$wpdb->prefix}redirection_modules.name AS module_name,{$wpdb->prefix}redirection_groups.name AS group_name,{$wpdb->prefix}redirection_groups.id FROM {$wpdb->prefix}redirection_groups INNER JOIN {$wpdb->prefix}redirection_modules ON {$wpdb->prefix}redirection_modules.id={$wpdb->prefix}redirection_groups.module_id ORDER BY {$wpdb->prefix}redirection_modules.name,{$wpdb->prefix}redirection_groups.position" ) );

to

$rows = $wpdb->get_results( "SELECT {$wpdb->prefix}redirection_modules.name AS module_name,{$wpdb->prefix}redirection_groups.name AS group_name,{$wpdb->prefix}redirection_groups.id FROM {$wpdb->prefix}redirection_groups INNER JOIN {$wpdb->prefix}redirection_modules ON {$wpdb->prefix}redirection_modules.id={$wpdb->prefix}redirection_groups.module_id ORDER BY {$wpdb->prefix}redirection_modules.name,{$wpdb->prefix}redirection_groups.position" );

Haven’t seen that behaviour, but I can’t see any way it would be related to the warning (or the fix for it): all the cleaner_gallery_get_setting method does is cache the settings that were in the database. You might want to start a new topic, though, since it’s a different bug than what you reported above.

Donncha – must be, given that I don’t remember writing or adding it! The bad plugin does kill the site exactly as described above, though—as soon as WP_CACHE is enabled the entire admin section goes to 500, with no browser output and (on DreamHost at least) no messages to the error log.

This patch stops shorturls from being generated for non-published posts, so it should prevent the wrong permalink from being added to the short URL list:

--- tweetbacks/tweetbacks.php
+++ tweetbacks/tweetbacks.php
@@ -343,7 +343,7 @@
 		return;
 	}
 	global $post;
-	if (!isset($post->ID) || $post->ID == 0 || $post->ID == "") {
+	if (!isset($post->ID) || $post->ID == 0 || $post->ID == "" || $post->post_status != 'publish') {
 		return;
 	} else {
 		$post_id = $post->ID;

I’m not sure if this is a complete fix, but it fixes the occurrence I was seeing: in function wpautop, add ins and del to the last two regexes that start with table|thead|. In 2.0 they’re on lines 72 and 74, on opposite sides of the single if ($br) condition.