raidenelite
Forum Replies Created
-
Hello, replacing the function seems to work! No need to change all the other functions like before.
Hopefully everything else works, and you can apply both fixes in the next updates and won’t need to come back to report it.
I appreciate the support.
I’m adding another report related to the use of custom admin and login URLs with plugins such as WP Hide & Security Enhancer and WP Ghost.
When trying to log in from
wp-adminand entering a wrong password, JS Help Desk intercepts thewp_login_failedaction and redirects the user to the JS Help Desk login page
The related function is located in: “includes/jsst-hooks.php”add_action('wp_login_failed', 'jssupportticket_login_failed', 10, 2);
function jssupportticket_login_failed($username)
{
$referrer = wp_get_referer();
if ($referrer && !strstr($referrer, 'wp-login') && !strstr($referrer, 'wp-admin')) {
if (isset($_POST['wp-submit'])) {
JSSTmessage::setMessage(esc_html(__('Username / password is incorrect', 'js-support-ticket')), 'error');
wp_redirect(jssupportticket::makeUrl(array('jstmod' => 'jssupportticket', 'jstlay' => 'login', 'jsstpageid' => jssupportticket::getPageid())));
exit;
} else {
return;
}
}
}The condition:
$referrer && !strstr($referrer, 'wp-login') && !strstr($referrer, 'wp-admin')only checks for the default WordPress URLs (
wp-loginandwp-admin).
This does not work when custom login/admin URLs are used, causing backend login failures to be incorrectly treated as frontend logins.Additionally, in my JS Help Desk settings I am using a custom login and registration URL (WooCommerce pages), not the “JS Help Desk Login Page”.
This redirect does not respect that configuration either and always forces the JS Help Desk login URL.
Please add a more robust check or a configurable option to handle these scenarios correctly when custom login and admin URL plugins are used, instead of relying on hard-codedwp-loginandwp-adminstring checks..Hello, this is not even the same code anymore
It was updated to this format after my post:if(jssupportticketphplib::JSST_strpos($wp_admin_path, "http") !== false) {
$wp_admin_path = ABSPATH . 'wp-admin/includes/plugin.php';
}i even switched from WP Hide & Security Enhancer to WP Ghosts since the last topic and the issue is the same
there has to be a permanent fix you can apply as many other plugins work fine with changing the admin path
a user would prefer not to have to edit the code manually each time
Thank you
Hi, can I report that I have the same problem, are you already working on it?
Forum: Plugins
In reply to: [Visibility Logic for Elementor] date & time not workingHello, update 2.3.8 still not available?
Hello, i can confirm that on my side it solved the issue!! Thank you, appreciated
Forum: Plugins
In reply to: [WooCommerce PayPal Payments] Dark icons not showing on blocksThank you for the information!
Forum: Plugins
In reply to: [WooCommerce PayPal Payments] Dark icons not showing on blocksHello, i mean these. Forgot to mention it’s for Advanced Card Processing
Hello, i’m having the exact same issue, guests can see Paypal but not the Advanced Card Processing if not logged in. This is on the new Checkout Block and i also tested in staging by deactivating ALL other plugins and on Storefront theme. I can’t understand where the issue comes from but i believe it may be in your plugin (maybe a setting or something else)
Hello, no problem!
I will open a ticket, do you want the system report with everything on or in the configuration asked previously?
Hello, i tried as asked but the Advanced Card Processing doesn’t even show on checkout in the asked configuration:
https://prnt.sc/pOtemFRg_WUWHello,
if i put the html code in the text editor like this:
http://prntscr.com/tdb96k
it previews correctly in “Visual”
http://prntscr.com/tdbb8ybut this was/is the result (doesn’t matter the client)
http://prntscr.com/tdbcv8i then realized that i have to put the code this way, making sure there is no new line after the html tags:
http://prntscr.com/tdbdzlthis way the email shows correctly but if i click on “Visual” and then Back on “Text” the code goes back to the first screenshot, messing up the email again
From what i found out the WP Editor is not the problem, it happens because of nl2br() as stated in the first post, but if you remove it the normal text also doesn’t have new lines.
Hope that’s clear
Cheers- This reply was modified 5 years, 10 months ago by raidenelite.
I can confirm this, when is the fix planned for?