Forum Replies Created

Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter robert_k

    (@robert_k)

    Well, it’s a search feature so there’s a couple of possibilities. I’ve renamed the post type, but this is the gist of the code:

    $params = array(
    	'posts_per_page' => -1,
    	'post_type'      => 'mycpt',
    	'post_status'    => 'publish',
    	'meta_key'       => 'type',
    	'orderby'        => array('meta_value' => 'DESC', 'date' => 'DESC')
    );
    
    if (empty($_GET)) {
    	$params['meta_query'][] = array(
    		'key'   => 'featured',
    		'value' => 1,
    		'type'  => 'NUMERIC'
    	);
    } else {
    	if (!empty($_GET['type'])) {
    		$params['tax_query'][] = array(
    			'taxonomy' => 'mycpt_type',
    			'terms' => array_map('intval', (array) $_GET['type']),
    		);
    	}
    
    	if (!empty($_GET['filters'])) {
    		$params['tax_query'][] = array(
    			'taxonomy' => 'mycpt_cat',
    			'terms' => array_map('intval', (array) $_GET['filters']),
    		);
    	}
    
    	if (!empty($_GET['search'])) {
    		$params['s'] = $_GET['search'];
    	}
    }
    
    $query = new WP_Query($params);
    
    if (!empty($params['s']) && function_exists('relevanssi_do_query')) {
    	relevanssi_do_query($query);
    }

    The searches that failed were against the “s” parameter only. But I’m wondering if the meta_key and order-by meta_value configuration could be the issue?

    You can play with the search form on this page to see what happens. The search box doesn’t respect the category/type taxonomies though the search logic supports it (that was requested). The only other thing I can think of is the fact we use the same query to loop twice: once for map pins, and a second time for the entries below the map.

    Thread Starter robert_k

    (@robert_k)

    You’re welcome Robin. Thanks for building a useful plugin.

    Thread Starter robert_k

    (@robert_k)

    Sorry guys, as far as I can tell the plugin owner never even attempted to contact me and has not dealt with the security issues I pointed out. The archive I posted has fixes for these security holes, but it isn’t an official update for the plugin.

    Thread Starter robert_k

    (@robert_k)

    Ikraav, so far as I know this issue has not been attended to. The last release was 8 months ago, and this issue affects version 1.4 (the current as of writing, still).

    I included a download link with my security fixes because of the severity of this problem:
    http://www.woodst.com/clients/woodstreet/username-changer.zip

    Thread Starter robert_k

    (@robert_k)

    Thanks Michael, that’ll come in handy in the future. We scoped the placeholder fallback script to the one form that needed it (so it wouldn’t create those fields).

    Thread Starter robert_k

    (@robert_k)

    Well, this is really inconvenient. We used a placeholder javascript that appears related to, if not a past version of the jquery-defaultvalue plugin. Apparently this has been one of our scripts for a long time, and it doesn’t have a script header to know where we got it from. (I never would have expected it to change the name attributes or go creating fields like it did…)

    Thanks for your help finding the culprit, Michael.

Viewing 6 replies - 1 through 6 (of 6 total)