salubritas
Forum Replies Created
-
Forum: Plugins
In reply to: [Ad Inserter - Ad Manager & AdSense Ads] Para word counting bug since v2.7.6Thank you. I have tested the development version on one article so far and the blocks are appearing in the same places as 2.7.5 so it seems good to me.
Will this fix go out in 2.7.8?
I’m going to put the password back on my staging site. Let me know if you still need access.
Forum: Plugins
In reply to: [Ad Inserter - Ad Manager & AdSense Ads] Para word counting bug since v2.7.6OK thanks
Forum: Plugins
In reply to: [Ad Inserter - Ad Manager & AdSense Ads] Para word counting bug since v2.7.6Assuming that position #9 is actually para #12, what I said about the clearance checks failing incorrectly still holds – not all of the two paras above and below para #12 have a heading above.
Forum: Plugins
In reply to: [Ad Inserter - Ad Manager & AdSense Ads] Para word counting bug since v2.7.6Hang on… positions are not the same as paragraphs it seems?
Forum: Plugins
In reply to: [Ad Inserter - Ad Manager & AdSense Ads] Para word counting bug since v2.7.6`I’ve manually installed the version suggested. WordPress said it was the same as the version installed, but I went ahead anyway.
With the clearance settings off, block #2s are inserted after paras 12, 21, 32, 44, 53. In each case the block has an ordinary paragraph above and below. The clearance settings I normally have check for images, headings, blockquotes, lists etc. one para above and one para below, so they shouldn’t make any difference right?
But with the clearance settings back I get just one block #2 showing, after para 21. The log shows it tried to insert a block at position 9 (this seems wrong – it should have ignored 3 paras with < 14 words). It is correct to fail the clearance check at para 9 (it has a heading above) so it then tries positions 10, 11, 8, 7. It thinks all of these fail the clearance check as well, but that is wrong. In each case it says it failed due to “ABOVE: <h”. But this is wrong, not all of those have a heading above.
So in summary, with clearance checks turned on, it seems to be counting paras that it shouldn’t because they have fewer than 14 words, and it also seems to be failing clearance checks that should pass.
Forum: Plugins
In reply to: [Ad Inserter - Ad Manager & AdSense Ads] Para word counting bug since v2.7.6Actually looking at the blocks that are now inserted I can’t see why they were failing the clearance settings anyway.
Forum: Plugins
In reply to: [Ad Inserter - Ad Manager & AdSense Ads] Para word counting bug since v2.7.6OK I have removed those settings and it is now inserting 5 of blocks #2.
So maybe it is not the word counting but the position shifting code that has changed? I had it set to try to shift position up to 2 paragraphs below then above.
Forum: Plugins
In reply to: [Ad Inserter - Ad Manager & AdSense Ads] Para word counting bug since v2.7.6Oops, enabled now.
Forum: Plugins
In reply to: [Ad Inserter - Ad Manager & AdSense Ads] Para word counting bug since v2.7.6Apologies, I went to disable that straight away but you must have got there before me. Please try again.
Forum: Developing with WordPress
In reply to: Comment count is wrong in admin with meta_query addedI have now reported in Trac.
Forum: Developing with WordPress
In reply to: Comment count is wrong in admin with meta_query addedHere’s a screenshot to make the issue clearer:
The number of comments is 3 but the table navigator says 45 comments over 3 pages.
Great, thank you.
That’s strange because I don’t find it to be intermittent at all. But as you have reproduced on a test site I will assume you have everything you need.
Hi, thanks for the reply.
Deactivating Rocket Loader does not help.
I first found this issue on my development environment with no Cloudflare or caching etc. of any sort. I have also tested with most plugins disabled.
- This reply was modified 5 years, 3 months ago by salubritas.
Thanks for the replies.
I already reinstalled the plugin and it did not clear the error.
No caching plugin on this dev environment.
However, the error has cleared now. I updated a few other plugins on my dev environment, so maybe there was some sort of clash or maybe it was PHP opcache. I’m using IIS and WinCache in dev.