sightfactory

Hi @nigelrsb we’re experiencing the same issue. It looks like the problem may be tied to the Elementor integration in the file SBY_Elementor_Base.php around lines 61 & 138 (\inc\Services\Integrations\Elementor\SBY_Elementor_Base.php.).
Basically there is a bug in that file creating broken CSS paths for sb-youtube-free.css and sb-youtube-common.css.

On the frontend, the browser then tries to load the malformed URL where the plugin base path is prepended to an already full URL.

I think what’s going on is that the helper function Util::getPluginAssets used in register_frontend_styles already returns a complete URL.

$css_common_file = Util::getPluginAssets('css', 'sb-youtube-common');

However, the code in SBY_Elementor_Base.php then tries to build the URL again by prepending SBY_PLUGIN_URL . ‘css/’ to that result ($css_common_file) and then becomes broken.

wp_register_style(
	'sby-common-styles',
	SBY_PLUGIN_URL . 'css/' . $css_common_file,
	array(),
	SBYVER
	);

The end result is that it inadvertently creates and tries to loads 2 broken links which slow down the website rendering while waiting for a timeout.
There’s also a potential secondary issue noticed that the enqueue used in the first part is using sby_common_styles (with underscores) but then registering later on as sby-common-styles (with hyphens)

I might be willing to upgrade and maintain the plugin but a quick glance shows it may need more patches than just the reported security issue to fully resolve issues and could take some time and effort to fork or re-submit it to the WordPress repository. Was there enough interest in the plugin previously to warrant updating it vs finding alternatives?