skirridsystems
Forum Replies Created
-
Forum: Plugins
In reply to: [OS DataHub Maps] Is Popup Anything safe to use?To be honest I’d not heard about the closure until now, which is why the documentation hasn’t changed
I found this notice added by the WP plugin team in 2.9.1.1
We would like to inform you that several plugins from the author “essentialplugin” have been reported by the community as not compliant with the guidelines. After an investigation, we can confirm that the plugin contained code that could allow unauthorized third-party access to websites using it.
In response, we have taken immediate steps to close the plugin in the ww.wp.xz.cn Plugins directory and release an update that already tried to remove affected code from your website. Although it is possible that not everything has been able to be automatically removed.
Specifically, this plugin downloaded code from analytics.essentialplugin.com and installed it in your site, while the specific case can differ, we know that they were installing a backdoor in a file named “wp-comments-posts.php” that looks closely to the core file “wp-comments-post.php”. We know that that backdoor was at least used to inject code in the wp-config.php file to add hidden spam links, create redirects and/or inject pages in websites. Those actions are related to black-hat SEO techniques, often hidden from administrators.
While our update attempted to remove the backdoor automatically, it cannot confirm that it was fully eliminated. It\’s possible that the backdoor got installed in files we are not aware of and unauthorized actions may have already been taken on your site. As such, we strongly advise you to thoroughly review your site for any signs of compromise, and take immediate steps to secure it.
So I would say no, not safe!
Forum: Plugins
In reply to: [OS DataHub Maps] Possible crash with invalid JSONFixed in 1.8.4
Forum: Plugins
In reply to: [OS DataHub Maps] Possible crash with invalid JSONThanks for the update, it was the single item in the array that was causing the test to miss. I’ll get the fixed version released soon.
And no, nothing you’ve done wrong. Wrong user data is expected to cause an incorrect display but it should never be able to cause a site crash.
Forum: Plugins
In reply to: [OS DataHub Maps] Possible crash with invalid JSONCan you send the markerfile that caused the crash? I tried removing the square brackets and the error was caught.
Forum: Plugins
In reply to: [OS DataHub Maps] Possible crash with invalid JSONThanks for the report. Invalid data definitely should not crash the website! There is some sanitisation but evidently not enough. I will look into this.
I had been thinking about moving the marker file interpreter into the client side Javascript, which would also reduce server load, but I’ve not had time to do it yet.
Forum: Plugins
In reply to: [OS DataHub Maps] Can marker files be read from Google Drive?No, it can’t because there are two formats of marker file distinguished by file extension. Google Drive generates a pseudo-random URL which has no extension, so the WordPress server can’t tell what type of file it’s looking at.
Forum: Plugins
In reply to: [OS DataHub Maps] How to add URL to markerSorry, meant to add the page is here:
https://skirridsystems.co.uk/os-datahub-maps/adding-markers/
Forum: Plugins
In reply to: [OS DataHub Maps] How to add URL to markerI’ve updated the documentation page to give a specific example for original and JSON format marker files.
Forum: Plugins
In reply to: [OS DataHub Maps] How to add URL to markerApologies, I wrote a reply and must have missed hitting the submit button.
You cannot use HTML in markers directly in the shortcode due to the way WordPress handles quoting and escaping. You’ll need to use a marker file.
https://skirridsystems.co.uk/os-datahub-maps/adding-markers/#markers-html
Forum: Plugins
In reply to: [TablePress - Tables in WordPress made easy] Internal cache problemGreat, thanks. I’ll install that plugin
Forum: Plugins
In reply to: [TablePress - Tables in WordPress made easy] Internal cache problemThanks! So this is a (very old) bug in the WP transients system where they can’t be deleted properly?
As the chances of that getting fixed any time soon are slim, is there a hook I can use to disable the caching in TablePress? The output should in any case be cached by my host’s caching system.
Simon
Forum: Plugins
In reply to: [OS DataHub Maps] Incorrect URLs for some default iconsThanks for the update, glad you found the source
Forum: Plugins
In reply to: [OS DataHub Maps] Incorrect URLs for some default iconsMaybe a conflict with WP Google Maps? Try disabling other plugins one at a time. Anyway, I’m pretty sure this does not originate within the OS Maps plugin or Leaflet.
Forum: Plugins
In reply to: [OS DataHub Maps] Incorrect URLs for some default iconsWait, I think I found it. The location is defined in the Leaflet style sheet and is relative to that style sheet. In a normal installation that stylesheet is located in the os-datahub-maps plugin directory. Your site seems to be inlining all the style sheets in the HTML, so relative paths then become relative to the page itself.
Do you have a cache plugin that’s doing this?
Forum: Plugins
In reply to: [OS DataHub Maps] Incorrect URLs for some default iconsWhere you specify a colour it uses the markerPath passed in. You do that for one of your locations (Farmborough & High Littleton) and that marker does indeed appear. All the others are using the Leaflet default marker, which is being referenced incorrectly.
But that post is 8 years old. I don’t see any issues relating to this in the current release on GitHub.
And it only seems to be happening on your instance. I’ve been using that version of Leaflet since Jan 2024 and no one else has come up against this