steve-pheriche

Further investigation, I’ve found the error in your plugin

Lines 547 and 550 of https://github.com/litespeedtech/lscache_wp/blob/master/lib/css-min/minifier.cls.php

       // Remove spaces before the things that should not have spaces before them.
        $body = preg_replace('/ ([:=,)*\/;\n])/S', '$1', $body);

        // Remove the spaces after the things that should not have spaces after them.
        $body = preg_replace('/([:=,(*\/!;\n]) /S', '$1', $body);

this will strip spaces around the asterisk character. “*”
that character needs spaces around it for calc()

raised it on GH
https://github.com/litespeedtech/lscache_wp/issues/405

• This reply was modified 4 years, 7 months ago by steve-pheriche.

Hi, OK. I’m aware that the Gutenberg Plugin is divergent.
I’m building a site which will launch shortly after WP5.8 . WP5.8 will have FSE, and the core and gutenberg teams are making big changes which is what we are seeing here. I’ll file a bug on Github Gutenberg regarding this issues but it’s put a cramp in my development cycle.

Just as long as the Astra team are aware of the breaking changes for the July release.

Here’s the Git report, it seemingly affects all themes. Gutenberg remains a disaster.
https://github.com/WordPress/gutenberg/issues/32274

• This reply was modified 5 years ago by steve-pheriche.
• This reply was modified 5 years ago by steve-pheriche.

Hi, Thanks for the prompt response.

Yeah, I did have a look through the code and couldn’t see a hook or filter.
I’d considered the CSS route, it feels a bit “hacky” to have the library in memory but hidden.

It might be good to provide a way for users to turn that feature off. I understand for small businesses with one person making their own site it’s probably good – but for web-devs supplying a concise editor to a client with 20 staff who have access to the Editor role … it’s a recipe for disaster!

I investigated forking to see if I can make the enqueue conditional on user role and an options page, or current_user_can().

For example: /plugins/editorplus/index.php (line 16)
require_once plugin_dir_path(__FILE__) . 'extendify-templates-sdk/class-templates-sdk.php';

But for now I’ve done a rather brutal local fork by commenting out the require_once , but thanks again for your work here with this plugin and the quick response.

– Steve

What I’ve done is de-queue the CSS. My CSS file is named gdpr-cookie-fork.css and I put it the functions.php in a child theme for my client. Like this …

/*** overwrite the cookie law CSS **/
function cookie_GDPR_style_fixes(){
  wp_dequeue_script('moove_gdpr_frontend');
  wp_enqueue_style( 'moove_gdpr_frontend', get_stylesheet_directory_uri().'/gdpr-cookie-fork.css' );
}
add_action('wp_enqueue_scripts', 'cookie_GDPR_style_fixes', 100);

Hi there. This site is running
PHP Version 5.6.3, WP version 4.9.6

the URL is currently a local dev server. I’m testing strategies for a client before committing.

I think I have found that the issue, a clash with another plugin. Unfortunately, it is clashing with a plugin I wrote myself – a front-end registration and login plugin.

the offending line in MY plugin (triggering the JSON error in yours) is this dashboard restriction and redirection for members. I’ll take a look at fixing my own error in this wonky looking action, but if you have any thoughts I’d welcome them.

function pher_restrict_dashboard_to_admin() {
    if ( !current_user_can( 'manage_options' )  && $_SERVER['PHP_SELF'] != '/wp-admin/admin-ajax.php' ) {
        wp_redirect(home_url('/member-portal/'));
    }
}
add_action( 'admin_init', 'pher_restrict_dashboard_to_admin', 1 );

commenting out the //add_action in my plugin will allow your plugin to add scripts without any JSON errors

• This reply was modified 7 years, 11 months ago by steve-pheriche.

Thanks xnau, I just wanted to make sure that my understanding was correct. I wouldn’t like to make a whole thumbnail system only to find that I had accidentally de-activated your own one.

yes, I’ll probably write something for the list view template which checks the returned uploaded image URL, and if it finds there is a thumb version (participants-database/myimage-150×150.jpg) it will use that variant, and if it does not find a thumb it will generate one for next time. That’s my plan anyway.

thanks for the response.