stratboy
Forum Replies Created
-
Did you took a closer look at this issue?
I checked the polylang plugin, but didn’t see it do anything with term_order. Could it be there is a different plugin or theme adding that join and orderby?I currently cannot verify this thing because my local version of the site does not suffer of this problem (don’t know why). And on the production version I cannot disable all the plugins to see. But what I can say is:
– if I disable yours, the problem is gone
– the query IS made by polylang, you can find query pieces on translated-post.php and translated-term.php files. Just search for pll_tr string, join_clause() funcion, rows 100 and 160.
- This reply was modified 4 years, 6 months ago by stratboy.
Ok, I already took a look to some more logs: I definitely believe you should refactor your code a bit: since term_order is in fact a native _term_relationships column, a lot of plugins could use it in their queries (like it seems polylang is doing), without namespacing it.
But it’s your plugin that alter the default database by adding a column to _terms. Thus, I think it should be your responsibility to carefully choose a name for that column that will not cause issues to others. Just rename that column namespaced, something different from any wordpress native column: something like ctne_term_order, and then update your code. That will fix the issue and prevent it from coming back if some other plugin will do queries using _term_relationships’s term_order column.
- This reply was modified 4 years, 6 months ago by stratboy.
I’ll write also to the polylang dev, since it could be a polylang issue.
It does not work. I took a look to your code: again, there are 2 tables with term_order column. _terms is the one you’re altering, _term_relationships already has term_order by design. In your queries, you must specify which term_order you’re using for the order query. Or, if possible, you could refactor your code to use the native _term_relationships.term_order, if applicable.
Both _terms and _term_relationships currently have a term_order column.
As the error states, Column ‘term_order’ in order clause is ambiguous. That means you should namespace that clause:ORDER BY term_order
Tell and write which term_order should be considered: t.term_order or pll_tr.term_order
That said, ‘pll_tr’ seems to come from polylang plugin, which is currently in use. Would you confirm?
Though, I can see from wp docs that term_id is native on _term_relationships, but it’s not on _terms. Is it added by your plugin?
Hey, I took a look to page source and I can see over 40 files (http requests) made by your plugin for loading css and js files. ???????
I tried, but I have to keep activated at least Polylang Pro and ACF Pro, otherwise my theme won’t work, and I guess UM should work at least with those 2 super used plugins.
Also, I’m a developer, the theme is developed by me. And you can speak tech.
The UM registration form won’t work both in your own default registration page, and in a specific page template, where I used
echo do_shortcode('[ultimatemember form_id="xxxx"]')to recall it.
Now, if my theme lacks something, you can tell me exactly what things should be there. What default wp theme features or code are required by your plugin?
I use my themes since almost 20 years ago now, and 99% of plugins do not have troubles. My themes are really barebones. Also, I tried out another registration plugin (User Registration) and it works properly (tested both on its own registration page and if recalled by do_shortcode like above).
Finally, by searching this forum, I’ve found out I’m not the only one with this exact issue.
So, I don’t think it’s something of my code. Or, at least, nothing so evident. Please tell me the exact requirements of your plugin or, try to verify the current release.
Thank you
- This reply was modified 5 years, 10 months ago by stratboy.
Just to subscribe.
Exact same here. And already try to recreate the things like suggested.
Also, as feature request:
In admin, every for should have:
– A default redirect page
– The ability to define a custom redirect page
– The ability to be rendered on any page via php instead of shortcodesThank you, regards
Hi, I already solved. It was me.
On my theme I deregistered jquery, renamed jquery_js to load v3, and deferred it. I kept v3 but renamed jquery as default and loaded without deferring it.
Though, in next versions, I think you could maybe add an option to defer your scripts too. Nowadays performance is really important. Or, if you’re naming/registering your scripts the standard way, you could add some docs to report their names and to show how to defer them. Something like:
if(!is_admin()) add_filter( 'script_loader_tag', 'wsds_defer_scripts', 10, 3 ); function wsds_defer_scripts( $tag, $handle, $src ) { $defer_scripts = array( 'your_mansory_script_name' ,'your_others...' ); if(in_array($handle, $defer_scripts)){ return '<script src="' . $src . '" defer="defer" type="text/javascript"></script>' . "\n"; } return $tag; }Forum: Developing with WordPress
In reply to: “Formats” with Gutenberg?Hi, same problem here. Any solution?
- This reply was modified 7 years ago by stratboy.
Me too me too! 🙂
Forum: Plugins
In reply to: [Polylang] Polylang compatibility with WP All ImportDone 🙂
Forum: Plugins
In reply to: [Polylang] Polylang compatibility with WP All Importthey already put it on hold… Try on stackoverflow then, they’re generally a little less stupid..