swinggraphics
Forum Replies Created
-
“The escape key issue is easy enough to fix, now on my list.”
Cheers!
As for stacked popups that need to sroll, my workaround is to add this CSS:
html.pum-open.pum-open-overlay.pum-open-scrollable {
overflow: revert;
}
html.pum-open.pum-open-overlay.pum-open-scrollable:has(.pum-active:not(.pum-overlay-disabled)) {
overflow: hidden;
}
html.pum-open.pum-open-overlay.pum-open-scrollable body>:not([aria-modal=true]) {
padding-right: 0 !important;
}
html.pum-open.pum-open-overlay-disabled.pum-open-fixed .pum-container:not(.fixed) {
position: static;
}These are now live on a site that I can share: https://visitmontauk.org/
I was able to reproduce this several times last week with a default theme and no other plugins, but I am not able to currently. I was going to make a recording with the network tab open and try to catch it as it happens, but it is not occurring now. Hopefully I can chalk this up to a server problem that somehow stopped being an issue. Sorry to waste your time! Thanks for responding. I’ll mark this resolved and reopen it or start a new one if I’m able to add anything useful.
Given that a previous suggestion from you folks was to disable the accessibility features, this response is a laughable attempt to dodge responsibility. Look: your pop-up shows automatically on page load, you press escape and then tab. Where does focus move? Outside the viewport. That is not a beneficial pattern for accessibility. My code is a perfectly good workaround for this case, but obviously your idea to set a valid focus prior to opening so that focus can return there on close would be even better. But you don’t say you would implement that in the plug-in, so your are not offering any kind of solution. So don’t mark this resolved when it’s not.
Overlays have absolutely nothing to do with this. Any given popup needs to be closable if that’s what the designer wants, or is required for accessibility, or necessary for the user experience. Completely disabling the ability to close a popup is not a solution. Clearly, your plugin simply needs to make the escape key work for only the foremost popup. I don’t even understand why this is a point of contention. The correct response is, “Oops, we missed that. We’ll fix it in a future version.” And that’s the end of it.
“Does the issue seem intermittent? Do you observe anything different during the times it did change?”
These are answered in my original post:
“Edits to this field are often not saved. (Change is not reflected on the frontend, and reloading the page shows the old value on the backend.) I have only experienced problems saving this field; no other data on the page seems to suffer from this. There is no particular pattern as to when this will fail. It can fail if that is the only edit I make, or when it is one of several.”
Here’s a solution for anyone else wanting to fix this behavior.
$( '.pum-overlay' ).on( 'pumAfterClose', function(){
if ( $( '.pum-active' ).length ) {
$( '.pum-active .pum-content' ).focus();
} else {
$( 'body' ).attr( 'tabindex', '-1' ).focus();
}
} );I’m already using 1.22.0. My original post is reporting a bug that exists in 1.22.0.
Part of the accessibility features for an auto-open popup should be returning focus to the top of the document after it is closed. Disabling the accessibility features obviously does not fix that in any way.
“Right now, the Popup Title field can only be edited in the Classic Editor.”
That is not true. Perhaps you mean, “Right now, the Popup Title field can only be edited reliably in the Classic Editor“? That is a very weird bug, which you should acknowledge as such.
Are you currently using the Classic Editor for Popups?
No
Have you tried ruling out plugin/theme conflicts as well?
Yes. Twenty Twenty-Five and no other plugins.
?? That’s not a good suggestion. Of course the behavior is different with that feature disabled, but it is, obviously, so much worse because it makes it completely broken for keyboard users.
3. Pressing the esc key closes all popups instead of just the active one.
- This reply was modified 1 month ago by swinggraphics.
Forum: Plugins
In reply to: [Find Blocks, Patterns & Shortcodes] Edit link does not work👍 Thanks!
Forum: Themes and Templates
In reply to: [Astra] Fatal error in breadcrumb trailI found that while the fatal error is generated by Astra, there is also a separate issue in our particular case, where Elementor is not using the 404 template. That separate issue is related to this bug report. I will mark this thread resolved, because if Elementor fixed their bug, this issue with Astra would not even appear.
- This reply was modified 1 month, 3 weeks ago by swinggraphics. Reason: Note about separate Elementor issue
Forum: Themes and Templates
In reply to: [Astra] Fatal error in breadcrumb trail- PHP 8.3 (also tested on 8.1)
- WP 6.9.4
- Astra 4.12.6
- Astra Pro 4.12.14
- Elementor 4.0.1
- Elementor Pro 4.0.1
These are the only active plugins.
- This reply was modified 1 month, 3 weeks ago by swinggraphics. Reason: Note about PHP 8.1