tenacityio
Forum Replies Created
-
@mohsinbsf I know why your devs think it’s needed but what I don’t understand is why it setup to impact the entire website.
“we’ve implemented a scan to detect when the lightbox is enabled and temporarily disable WebP image conversion on those pages.” In Version 2.19.16? Please clarify.
We are seeingpictureshutoff across the entire website, unless we implement the patch above, which I would consider a temporary hotfix, since all it really does it reruns the imagify picture tag replacement.
We don’t use the Spectra Image Gallery or lightbox on the site at all, and it impact the entire site. I’ve turned off Image Gallery in the settings panel, which looking at the code it’s clear this doesn’t actually stop the Image Gallery class. So, it affects pages that don’t have a single Spectra block.
Let me explain again and provide a potential fix
In ultimate-addons-for-gutenberg/blocks-config/image-gallery/class-spectra-image-gallery.php
The issue is whenclass Spectra_Image_Galleryis initiated (~ line 17), which will be always, the Imagify nextgen picture tags are turned off (~ line 58), it only turns back on when it when an Image Gallery is rendered (~ line 1089). That means that if any page doesn’t have an Image Gallery on it, the next gen will be turned off, because Image nextgen picture tags will be turned off but never turned back on. So, the plugin effectively turns it off on the entire website, with potentially one exception of page with Image Galleries on it after they are rendered, I haven’t tested this.
The potential fix
Remove the filters and add Imagify nativeimagify-no-webpclass to any and all images in the Image Gallery. This ensures those of us that prefer using the Imagify picture tag don’t have our sites broken, those that use the Imagify htaccess method will be unaffected and Spectra image gallery will be excluded from the picture tag rendering issues.Respectfully, that’s not correct, about the buffering
This adds the action lightweight_webp_fix to every page loadadd_action( 'template_redirect', 'lightweight_webp_fix', 1 );This says buffer output when next gen images are turned on, which is the purpose of Imagify.
if ( get_imagify_option( 'display_nextgen' ) ) {
add_action( 'template_redirect', function() {
ob_start( function( $buffer ) {
return apply_filters( 'imagify_process_webp_content', $buffer );
});
}, 101 );
}So, if next gen images are on, which it would be on the entire website, the output buffers on every page.
I guess it’s correct, in that the issue affects the entire website because the Spectra Gallery isn’t properly scoped. Two things can be true, I suppose. But this is a workaround that introduces a global performance issue, in place of another global performance issue, not a fix.
Just to clarify doesn’t this require us to buffer every single page on the website?
Forum: Fixing WordPress
In reply to: Open in New Tab ToggleThey had added the checkbox back in on the link preview in 6.4, so at least it reduced the total number of clicks and unhid the option. But once again, they removed it in 6.5, which is very frustrating.
- This reply was modified 2 years, 1 month ago by tenacityio.
Forum: Plugins
In reply to: [CMB2] PHP Errors and JavaScript Issues@jtsternberg That seems to have eliminated the error and restored the editor. Thank you! That would have taken forever to figure out.
Forum: Plugins
In reply to: [CMB2] PHP Errors and JavaScript IssuesSure here is all of the related PHP code that use CMB2 in the theme.
https://gist.github.com/tenacityio/a6d3afb28a8192677431b53d610567d1Forum: Plugins
In reply to: [CMB2] PHP Errors and JavaScript IssuesRegistration Code? Like an activation code for the plugin?
Or do you mean the theme code that uses CMB2?Forum: Plugins
In reply to: [CMB2] PHP Errors and JavaScript IssuesIt’s not just Gamipress.
When activated, it reports the following error. (Gamipress not active.) I look at it, and basically, it’s using call_user_func but not limiting parameters.
https://help.tenacity.io/rRu5r0nlWhen activated, it also breaks the Standard Editor and WP Bakery (but only on Pages), which makes sense because it’s only being used for Pages in our theme.
https://help.tenacity.io/Jruy0qwR
I think this is likely two separate issues. Gamipress activation generates the same errors since they use CMB2 as a library.
I found the following
https://stackoverflow.com/questions/34116787/cmb2-tinymce-menu-bar-not-showing
But I’ve been through our theme code, and we don’t use wysiwyg fields, so it didn’t apply. Perhaps there is something else?Forum: Plugins
In reply to: [All-In-One Security (AIOS) – Security and Firewall] NGINX SupportOk, thanks. I can probably generate something, based on a baseline wordpress install. Or perhaps from the plugin code, but if it existed already it would be helpful.
Forum: Plugins
In reply to: [All-In-One Security (AIOS) – Security and Firewall] NGINX SupportFollow up do you have all the rules that AOIS writes to htaccess as a reference or in documentation?
Forum: Plugins
In reply to: [OneSignal - Web Push Notifications] Caching CSS Files@onesignal To be clear, it’s the CSS files that the Service Worker is caching that matter to us and causing issues.
Is there no way to clear those or prevent them from being cached?
Why does a push notification script need to cache CSS?@karinapremio Found it.
@karinapremio… yes, is there a way to stop the bar from hiding?
Sorry for the delay.
We just want to “show the bar when the user refreshes the page or visits another page.” Or really just the option to not hide the bar at all.
How is this resolved?