Tofandel
Forum Replies Created
-
I did enable this option but I don’t have any Headers section on the Notification page. That’s why I went with a filter
I was able to do that with a filter
add_filter('notification/carrier/email/headers', function ($headers, Email $email, Triggerable $trigger) {
if ($trigger instanceof ContactNotification) {
$tags = $trigger->getMergeTags();
$keyedTags = [];
foreach ($tags as $tag) {
$keyedTags[$tag->getSlug()] = $tag;
}
$headers[] = 'Reply-To: ' . $keyedTags['last_name']?->getValue() . ' ' . $keyedTags['first_name']?->getValue() . ' <' . $keyedTags['email']?->getValue() . '>';
}
return $headers;
}, 10, 3);A plugin cannot and should not autoupdate to a major version. Unless you are using some thrid party auto upgrading software, a major version upgrade should always be a manual operation
Had the same issue, this was caused by the “Advanced > Crawl Optimizations > Remove unregistered url parameters” checked in premium, but it was still active but not visible and uncheckable when the non premium version was in use
We should also be able to edit which thumb size we want this plugin to apply to
Right now it applies to all of them, which is very undesirableForum: Plugins
In reply to: [EWWW Image Optimizer] External images with lazy loading are brokenIt seems that the file has the url html encoded, which is then passed to esc_url (but the wordpress forum decodes them so it does not show correctly in the above output)
I’m providing a pastebin here with the html needed to reproduce the issue
https://pastebin.com/y85qNjEt
If you have this html in your page (which is valid html according to the specs, html attributes can be html encoded), EWWW will choke on this image and output it as http://https://
So it seems the output of get_images_from_html is missing an html_entity_decode
This is the line I changed to have it output correctly$file = \str_replace( '&038;', '&', \esc_url( \trim( $file ) ) );$file = \esc_url( \trim( html_entity_decode( $file ) ) );- This reply was modified 1 year, 11 months ago by Tofandel.
- This reply was modified 1 year, 11 months ago by Tofandel.
- This reply was modified 1 year, 11 months ago by Tofandel.
- This reply was modified 1 year, 11 months ago by Tofandel.
- This reply was modified 1 year, 11 months ago by Tofandel.
- This reply was modified 1 year, 11 months ago by Yui.
Forum: Plugins
In reply to: [EWWW Image Optimizer] External images with lazy loading are brokenNot that I know, I disabled every other plugin
This is the code when EWWW lazyloading is enabled (and before js runs)<img class="img lazyload" src="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" data-src="http://https://static.apidae-tourisme.com/filestore/objets-touristiques/images/254/220/12967166-diaporama.jpg" decoding="async"><noscript><img class="img" src="https://static.apidae-tourisme.com/filestore/objets-touristiques/images/254/220/12967166-diaporama.jpg" data-eio="l"></noscript>This is the code when EWWW is disabled
<img class="img" src="https://static.apidae-tourisme.com/filestore/objets-touristiques/images/254/220/12967166-diaporama.jpg">Relevant debug log
<b>EWWW\Lazy_Load::validate_image_tag()</b>
<b>EWWW\Base::is_lazy_placeholder()</b>
found a valid image tag
original image tag: <img class="img" src="https://static.apidae-tourisme.com/filestore/objets-touristiques/images/254/220/12967166-diaporama.jpg">
<b>EWWW\Lazy_Load::parse_img_tag()</b>
<b>EWWW\Page_Parser::get_image_dimensions_by_url()</b>
getting dimensions for http://https&#x3A;&#x2F;&#x2F;static.apidae-tourisme.com&#x2F;filestore&#x2F;objets-touristiques&#x2F;images&#x2F;254&#x2F;220&#x2F;12967166-diaporama.jpg
<b>EWWW\Page_Parser::get_dimensions_from_filename()</b>
looking for dimensions in http://https&#x3A;&#x2F;&#x2F;static.apidae-tourisme.com&#x2F;filestore&#x2F;objets-touristiques&#x2F;images&#x2F;254&#x2F;220&#x2F;12967166-diaporama.jpg
<b>EWWW\Base::url_to_path_exists()</b>
trying to find path for http://https&#x3A;&#x2F;&#x2F;static.apidae-tourisme.com&#x2F;filestore&#x2F;objets-touristiques&#x2F;images&#x2F;254&#x2F;220&#x2F;12967166-diaporama.jpg
not a valid local image
width attr: and height attr:
detected memory limit is: 270532608Forum: Plugins
In reply to: [Polylang] Polylang broke permanent linksI’m also having a similar issue, whenever I change a theme option, any page shows the blog page, debugging shows that it takes the first part of the path as a language but we enabled the hide default language setting
So we have to go and uncheck this checkbox and check it again for it to work and the issue comes back very often
Any news? This simple fix is still pending, you can check the source by yourself there
https://plugins.trac.ww.wp.xz.cn/browser/bdthemes-element-pack-lite/trunk/assets/js/ep-scripts.js#L9088Please check the file path I gave, not the localization from the php file
I mentionned that the localization exists but is hardcoded in the js file and thus ineffective
See how the string
SEARCH RESULTis hardcoded
It should be${window.ElementPackConfig.search.search_result}Sorry, did you read my message?
The string is HARDCODED, it’s not translatableForum: Plugins
In reply to: [Polylang] Broken post categories linksIn addition, the language of “Non classé” is set to English (I guess it doesn’t have one) but if I change it and save it, it stays the same
Forum: Plugins
In reply to: [Fast Velocity Minify] Invalid css minificationLike this:
$enc = mb_detect_encoding($str, array_filter(mb_list_encodings(), function($enc) { return strpos($enc, "UTF-7") !== 0; }), true);
Tested that it fixes the issueForum: Plugins
In reply to: [Fast Velocity Minify] Invalid css minificationhttps://github.com/php/php-src/issues/10192
Maybe we can remove UTF-7 from the mb_list_encodings() as a workaround- This reply was modified 3 years, 4 months ago by Tofandel.
Forum: Plugins
In reply to: [Fast Velocity Minify] Invalid css minificationI have located the issue to the
fvm_ensure_utf8function
It’s an issue with php8.1+ only
https://onlinephp.io?s=ZZFvS8MwEMZfr9DvcHaDtTjZQISxWnznJ9BXIiVLrmuwTUr-DIf43b00rlMWEkjufnmey-XxaWiHNJkDKusNgmuZA-uMVAeQFrxrtrM0abziTmoFzbGvI1mHVL4gtICvNJktUHGooN_XAh1yRxjXgmRGZhUSnbSXsM2LFTjjsSjp9pGZWvh-yIPMGJEN5FGzqqBhncUi2MwMOm9UjJSwXgPXvhOgtINoDGcHor8BCYNJ64a0steX57ttFqs-y1F1XKsjmqu6f_EVxMqi40iiAKfHDl2c_mqG-yPPOoNMnCaUFs05vUF2tPn3ojShdJosuLXUzaVUg3dv7jRglRkmpM7ed7xF_kHmtyD7Q3AEGnttBJodPAyfYHUnBcw3m-09Z0FxWU6KVx9I4dBv5K2GcKD9Dw%2C%2C&v=8.2.1%2C8.1.14%2C8.0.27- This reply was modified 3 years, 4 months ago by Tofandel.